chore: add e2e tests #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
added a commit
to valora-inc/typescript-app-starter
that referenced
this pull request
Apr 18, 2024
Noticed the deprecation as I was working on valora-inc/viem-account-hsm-gcp#6
kathaypacific
approved these changes
Apr 19, 2024
kathaypacific
left a comment
kathaypacific
left a comment
There was a problem hiding this comment.
LGTM, curious why you decided on a send.e2e.ts file in the scripts folder? it seems like it just calls the actual test file, what's the difference between using a script in the package.json with something like jest *.e2e.ts?
Member
Author
|
Ah yes it's just to show that it's an e2e test for the send script. |
bakoushin
approved these changes
Apr 19, 2024
bakoushin
left a comment
bakoushin
left a comment
There was a problem hiding this comment.
Is there a way to run e2e test locally?
jeanregisser
force-pushed
the
jeanregisser/add-provenance
branch
from
d910480 to
2642bdb
Compare
jeanregisser
force-pushed
the
jeanregisser/e2e-test
branch
from
49d86c5 to
471f5c0
Compare
Member
Author
|
Yes with |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the lib keeps working with a real GCP HSM going forward.
Quite similar to the unit test, so you may see some duplication in the structure of the test.
Which is fine/expected I think.
Fixes RET-1037