-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[WIP] Rename all files from redis* to valkey* #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9f186a4
Change variable REDIS_* to VALKEY_*
gaod 682c5e4
Move redisassert.* to valkeyassert.*
gaod dfad075
Move redis-check-aof to valkey-check-aof
gaod d3c1255
Move redis-benchmark to valkey-benchmark
gaod 321830d
Move redis-check-rdb to valkey-check-rdb
gaod a9834bc
Move redis-cli to valkey-cli
gaod fcb53e2
Move redis-trib to valkey-trib
gaod b61e4bd
Move redismodule.h to valkeymodule.h
gaod ad9f229
Move tests/integration/redis-benchmark.tcl to tests/integration/valke…
gaod f53d4e8
Rename REDIS_VERSION_NUM to VALKEY_VERSION_NUM
gaod d8c695d
Update deps/hiredis/adapters/redismoduleapi.h
gaod 28f217c
Update deps/hiredis/examples/example-redismoduleapi.c
gaod 51f2a10
Update src/module.c
gaod 93c3998
Update src/module.c
gaod f1ca592
Update src/module.c
gaod a008e82
Update src/module.c
gaod 8eb21b2
Update src/module.c
gaod ed1fe17
For additional compatibility this adds REDIS_CFLAGS and REDIS_LDFLAGS…
roshkhatri eb3f707
Doc add SECURITY.md link inside CONTRIBUTING.md (#96)
vitahlin c518ae9
Change redis-server related path or wording to valkey-server
gaod 48c44a5
Change utils/redis_init_script.tpl to utils/valkey_init_script.tpl
gaod 8d8d83a
Revert "Move redismodule.h to valkeymodule.h"
gaod 7fd01b8
Revert "Move redis-trib to valkey-trib"
gaod 3682651
Change valkeyassert.* to serverassert.*
gaod e6101b8
Merge branch 'unstable' into rename-from-redis-to-valkey
gaod dc03b9a
Replace the wording of 'redis-' to 'valkey-'
gaod 09b2a12
Change REDIS_BUILD_ID_RAW ot VALKEY_BUILD_ID_RAW to avoid compiling e…
gaod 2f4ea77
Rename redis_unreachable() to valkey_unreachable()
gaod 212c3e4
Change REDIS_VERSION to VALKEY_VERSION
gaod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,21 +37,21 @@ To manually run a Redis server with TLS mode (assuming `gen-test-certs.sh` was | |
| invoked so sample certificates/keys are available): | ||
|
|
||
| For TLS built-in mode: | ||
| ./src/redis-server --tls-port 6379 --port 0 \ | ||
| ./src/valkey-server --tls-port 6379 --port 0 \ | ||
| --tls-cert-file ./tests/tls/redis.crt \ | ||
| --tls-key-file ./tests/tls/redis.key \ | ||
| --tls-ca-cert-file ./tests/tls/ca.crt | ||
|
|
||
| For TLS module mode: | ||
| ./src/redis-server --tls-port 6379 --port 0 \ | ||
| ./src/valkey-server --tls-port 6379 --port 0 \ | ||
| --tls-cert-file ./tests/tls/redis.crt \ | ||
| --tls-key-file ./tests/tls/redis.key \ | ||
| --tls-ca-cert-file ./tests/tls/ca.crt \ | ||
| --loadmodule src/redis-tls.so | ||
|
|
||
| To connect to this Redis server with `redis-cli`: | ||
| To connect to this Redis server with `valkey-cli`: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this "To connect to this |
||
|
|
||
| ./src/redis-cli --tls \ | ||
| ./src/valkey-cli --tls \ | ||
| --cert ./tests/tls/redis.crt \ | ||
| --key ./tests/tls/redis.key \ | ||
| --cacert ./tests/tls/ca.crt | ||
|
|
@@ -85,12 +85,12 @@ but there are probably other good reasons to improve that part anyway. | |
| To-Do List | ||
| ---------- | ||
|
|
||
| - [ ] redis-benchmark support. The current implementation is a mix of using | ||
| - [ ] valkey-benchmark support. The current implementation is a mix of using | ||
| hiredis for parsing and basic networking (establishing connections), but | ||
| directly manipulating sockets for most actions. This will need to be cleaned | ||
| up for proper TLS support. The best approach is probably to migrate to hiredis | ||
| async mode. | ||
| - [ ] redis-cli `--slave` and `--rdb` support. | ||
| - [ ] valkey-cli `--slave` and `--rdb` support. | ||
|
|
||
| Multi-port | ||
| ---------- | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.