Skip to content

Changed links and naming to valkey instead of redis #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 2, 2024
Merged

Changed links and naming to valkey instead of redis #389

merged 9 commits into from
May 2, 2024

Conversation

@simkusr
Copy link
Contributor

@simkusr simkusr commented Apr 26, 2024 •
edited by zuiderkwast
Loading

This is a minor change where only naming and links now points properly to valkey.

Fixes #388

@simkusr simkusr marked this pull request as draft April 26, 2024 11:11
@simkusr
Copy link
Contributor Author

simkusr commented Apr 26, 2024

non trivial naming conventions were changed from redis to valkey.

@simkusr simkusr marked this pull request as ready for review April 26, 2024 11:33
@simkusr
Copy link
Contributor Author

simkusr commented Apr 26, 2024

There are still left redis naming, but those ones require additional testing for scripts and more, it's different then this simple PR. With this PR I had an idea to rename from Redis to Valkey where the most we can see it, other require code changes so its out of this PR scope.

@simkusr simkusr mentioned this pull request Apr 26, 2024
Closed
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
@simkusr
Copy link
Contributor Author

simkusr commented Apr 29, 2024

@madolson thanks for review, did the rollback and changes you mentioned, thanks again!

zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
madolson
madolson reviewed May 1, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (b0d5a0f) to head (e606834).
Report is 10 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable     #389      +/-   ##
============================================
+ Coverage     68.33%   68.43%   +0.09%     
============================================
  Files           108      109       +1     
  Lines         61563    61671     +108     
============================================
+ Hits          42072    42206     +134     
+ Misses        19491    19465      -26

see 20 files with indirect coverage changes

@zuiderkwast zuiderkwast added the rebranding Valkey is not Redis label May 2, 2024
@zuiderkwast zuiderkwast merged commit 68ca258 into valkey-io:unstable May 2, 2024
PingXie pushed a commit to PingXie/valkey that referenced this pull request May 2, 2024
@simkusr @zuiderkwast @PingXie
Changed links and naming to valkey instead of redis (valkey-io#389)
758ecd8 
This is a minor change where only naming and links now points properly
to valkey.

Fixes valkey-io#388

---------

Signed-off-by: Rolandas Šimkus <[email protected]>
Signed-off-by: simkusr <[email protected]>
Signed-off-by: simkusr <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Co-authored-by: simkusr <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madolson madolson madolson left review comments

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees

No one assigned

Labels

rebranding Valkey is not Redis

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

naming conventions and links should be changed from redis to valkey

3 participants

@simkusr @zuiderkwast @madolson