-
Notifications
You must be signed in to change notification settings - Fork 947
Fix cluster slot migration flaky test #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
enjoy-binbin
merged 14 commits into
valkey-io:unstable
from
hanxizh9910:fix/cluster-slot-migration-flaky-test-2693
Nov 20, 2025
+8
−1
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e019e0d
Deflake cluster-slot-migration-flaky-test-2693
hanxizh9910 1b23963
Added two files to test the flaky test
hanxizh9910 5bca61b
Fixed a yml format issue
hanxizh9910 a3c8eb9
Added a missing line in the test
hanxizh9910 440c04a
With Fix, check to see if any test fail
hanxizh9910 be33235
Removed the old fix
hanxizh9910 1669e08
Removed the redundant cluster_known_nodes call
hanxizh9910 057ca1e
Fix: added new fix to deflake the test, waiting for the owner node to…
hanxizh9910 8502965
Rewrote the fix
hanxizh9910 5c9be0e
Wrap the logic into a single expression
hanxizh9910 1a136a3
Fix, added check to make sure the owner node knows the new node
hanxizh9910 d4b228a
Deleted two test files
hanxizh9910 eccd523
Added code to ensure that all the nodes actually believe each other a…
hanxizh9910 2708cdb
Refactor: merge the fix with a previous step
hanxizh9910 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.