Skip to content

Initialize the lua attributes of the luaFunction script #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

Initialize the lua attributes of the luaFunction script #2750

merged 1 commit into from
Oct 20, 2025

Conversation

@enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Oct 19, 2025 •
edited
Loading

This was introduced in #1826. This create an Uninitialised value was created by a heap allocation in the CI.

enjoy-binbin
enjoy-binbin commented Oct 19, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.61%. Comparing base (2a914aa) to head (60055c8).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #2750      +/-   ##
============================================
- Coverage     72.64%   72.61%   -0.03%     
============================================
  Files           128      128              
  Lines         71300    71302       +2     
============================================
- Hits          51794    51775      -19     
- Misses        19506    19527      +21
Files with missing lines Coverage Δ
src/lua/function_lua.c 98.26% <100.00%> (+0.01%) ⬆️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enjoy-binbin enjoy-binbin requested a review from rjd15372 October 19, 2025 15:38
rjd15372
rjd15372 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@rjd15372 rjd15372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@rjd15372 rjd15372 added the bug Something isn't working label Oct 20, 2025
@rjd15372 rjd15372 mentioned this pull request Oct 20, 2025
Merged
@zuiderkwast zuiderkwast moved this to In Progress in Valkey 9.0 Oct 20, 2025
@zuiderkwast zuiderkwast merged commit 5d3cb3d into valkey-io:unstable Oct 20, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to To be backported in Valkey 9.0 Oct 20, 2025
@enjoy-binbin enjoy-binbin deleted the fix_lua branch October 20, 2025 10:30
cherukum-Amazon pushed a commit to cherukum-Amazon/valkey that referenced this pull request Oct 21, 2025
@enjoy-binbin @cherukum-Amazon
Initialize the lua attributes of the luaFunction script (valkey-io#2750)
1989b1e 
This was introduced in valkey-io#1826. This create an `Uninitialised value was
created by a heap allocation` in the CI.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 5d3cb3d)
Signed-off-by: cherukum-amazon <[email protected]>
diego-ciciani01 pushed a commit to diego-ciciani01/valkey that referenced this pull request Oct 21, 2025
@enjoy-binbin @diego-ciciani01
Initialize the lua attributes of the luaFunction script (valkey-io#2750)
571b480 
This was introduced in valkey-io#1826. This create an `Uninitialised value was
created by a heap allocation` in the CI.

Signed-off-by: Binbin <[email protected]>
zuiderkwast pushed a commit to cherukum-Amazon/valkey that referenced this pull request Oct 21, 2025
@enjoy-binbin @zuiderkwast
Initialize the lua attributes of the luaFunction script (valkey-io#2750)
5d7d2e5 
This was introduced in valkey-io#1826. This create an `Uninitialised value was
created by a heap allocation` in the CI.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 5d3cb3d)
Signed-off-by: cherukum-amazon <[email protected]>
madolson pushed a commit that referenced this pull request Oct 21, 2025
@enjoy-binbin @madolson
Initialize the lua attributes of the luaFunction script (#2750)
28cf7ba 
This was introduced in #1826. This create an `Uninitialised value was
created by a heap allocation` in the CI.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 5d3cb3d)
Signed-off-by: cherukum-amazon <[email protected]>
@cherukum-Amazon cherukum-Amazon moved this from To be backported to Done in Valkey 9.0 Nov 3, 2025
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 15, 2025
@enjoy-binbin @zhijun42
Initialize the lua attributes of the luaFunction script (valkey-io#2750)
0c20d87 
This was introduced in valkey-io#1826. This create an `Uninitialised value was
created by a heap allocation` in the CI.

Signed-off-by: Binbin <[email protected]>
zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Nov 15, 2025
@enjoy-binbin @zhijun42
Initialize the lua attributes of the luaFunction script (valkey-io#2750)
c94059e 
This was introduced in valkey-io#1826. This create an `Uninitialised value was
created by a heap allocation` in the CI.

Signed-off-by: Binbin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjd15372 rjd15372 rjd15372 approved these changes

Assignees

@enjoy-binbin enjoy-binbin

Labels

bug Something isn't working

Projects

Valkey 9.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enjoy-binbin @rjd15372 @zuiderkwast