Fix memory leak in deferred reply buffer

[uriyage]

Set free method for deferred_reply list to properly clean up
ClientReplyValue objects when the list is destroyed

This was introduced in #1819.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.22%. Comparing base (fab2a12) to head (5731d8b).
⚠️ Report is 2 commits behind head on unstable.

Files with missing lines	Patch %	Lines
src/networking.c	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #2615      +/-   ##
============================================
- Coverage     72.26%   72.22%   -0.04%     
============================================
  Files           127      127              
  Lines         70826    70828       +2     
============================================
- Hits          51180    51159      -21     
- Misses        19646    19669      +23     

Files with missing lines	Coverage Δ
src/networking.c	88.22% <0.00%> (-0.06%)	⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ranshid]

So this case of memory leak is when the client will be freed before the blocked command is sent over the network correct? Can you explain the exact path that can lead to such a case? also maybe we should explain more on the top comment.

I also think we should include a test for this case as there was no test of that path added.

[ranshid]

@yairgott can you PTAL?

[yairgott]

Thanks for fixing this!

IMO, It would be more intuitive if the default free function of a list is zfree while listSetFreeMethod is used to override.