Rename Redis to Valkey in the crash report.#253
Closed
zhulipeng wants to merge 3 commits intovalkey-io:unstablefrom
Closed
Rename Redis to Valkey in the crash report.#253zhulipeng wants to merge 3 commits intovalkey-io:unstablefrom
zhulipeng wants to merge 3 commits intovalkey-io:unstablefrom
Conversation
madolson
approved these changes
Apr 8, 2024
Member
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
I totally forgot about this, this is another thing to backport.
Signed-off-by: Lipeng Zhu <[email protected]>
Signed-off-by: Lipeng Zhu <[email protected]>
enjoy-binbin
approved these changes
Apr 8, 2024
enjoy-binbin
changed the title
Member
Author
|
Resolved in #263. |
Member
|
@lipzhu I would keep this open. We may still want to apply the changed on |
Member
Author
Ok, reopen the PR and solve the conflicts. |
Signed-off-by: Lipeng Zhu <[email protected]>
madolson
added
the
breaking-change
Member
|
Thanks, we need to decide if this is a breaking change, putting it in the 8.0 project for the time being. |
Contributor
|
This is a potential candidate for configurable redis compat mode. #274 |
Member
Author
|
Solved in #306. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch try to correct the server crash report.
Rename Redis to Valkey.