Try to stabilize aof test #2399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarthak Aggarwal <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2399 +/- ##
============================================
- Coverage 71.49% 71.29% -0.20%
============================================
Files 123 123
Lines 67179 67179
============================================
- Hits 48028 47894 -134
- Misses 19151 19285 +134 🚀 New features to boost your workflow:
|
Contributor
|
Please add to relevant projects for backporting. Flaky tests in old release branches is a pain too. |
Contributor
|
I'm guessing we need this for 7.2, 8.0 and 8.1. Please change if I'm wrong. |
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 15, 2025
Based on @enjoy-binbin's suggestion on valkey-io#1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved valkey-io#1611 Signed-off-by: Sarthak Aggarwal <[email protected]>
Merged
Contributor
Author
|
@zuiderkwast does it need manual backports to those branches? I can help cherry-pick the change and raise a PR. |
Contributor
|
So far, we've been backporting them when we're doing the next release. We just cherry-pick all of them into a PR and then we merge it without squashing the commits. We just look at the project board for each version under the to-be-backported column. I'm already picking this one to 8.0 in #2210. I'm reviving it. |
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 21, 2025
Based on @enjoy-binbin's suggestion on valkey-io#1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved valkey-io#1611 Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
pushed a commit
that referenced
this pull request
Aug 22, 2025
Based on @enjoy-binbin's suggestion on #1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved #1611 Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Sep 16, 2025
Based on @enjoy-binbin's suggestion on valkey-io#1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved valkey-io#1611 Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Sep 30, 2025
Based on @enjoy-binbin's suggestion on valkey-io#1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved valkey-io#1611 Signed-off-by: Sarthak Aggarwal <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Sep 30, 2025
Based on @enjoy-binbin's suggestion on valkey-io#1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved valkey-io#1611 Signed-off-by: Sarthak Aggarwal <[email protected]>
Contributor
|
7.2 doesn't have this test case, so nothing to backport. |
zuiderkwast
pushed a commit
that referenced
this pull request
Oct 1, 2025
Based on @enjoy-binbin's suggestion on #1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo. Resolved #1611 Signed-off-by: Sarthak Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @enjoy-binbin's suggestion on #1611, I made the change to find the available port. The test has been passing in the daily tests in my local repo.
Some passed tests:
Resolved #1611