valkey-cli: Fix dbid reset after error in MULTI #2357
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing #2309 and found that if you do
MULTI, SELECT incorrect dbid and EXECcombination of commands, then database ID right next to valkey-server address won't change, but it should. Turns out, for this combination of commands reply->type isVALKEY_REPLY_ARRAY, which was added to if statement for EXEC handling.