Skip to content

Fix leak when shrinking a hashtable without entries #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2025
Merged

Fix leak when shrinking a hashtable without entries #2288

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e94c176
Fix hashtable resize function to handle edge case
yzc-yzc Jun 30, 2025
7f6b444
Update src/hashtable.c
yzc-yzc Jul 1, 2025
574dee1
Add compactBucketChain when the hashtable is not rehashing in scan fu…
yzc-yzc Jul 1, 2025
597ffbe
Add test for testing that Active expiration triggers hashtable shrink
yzc-yzc Jul 1, 2025
802c76c
The test case need debug command
yzc-yzc Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hashtable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ static int resize(hashtable *ht, size_t min_capacity, int *malloc_failed) {
if (ht->type->rehashingStarted) ht->type->rehashingStarted(ht);

/* If the old table was empty, the rehashing is completed immediately. */
if (ht->tables[0] == NULL || ht->used[0] == 0) {
if (ht->tables[0] == NULL) {
rehashingCompleted(ht);
} else if (ht->type->instant_rehashing) {
while (hashtableIsRehashing(ht)) {
Expand Down
Loading