fix: use replica's last selected db for dual-channel sync #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2188 +/- ##
============================================
- Coverage 71.55% 71.51% -0.05%
============================================
Files 122 122
Lines 66493 66493
============================================
- Hits 47579 47550 -29
- Misses 18914 18943 +29
🚀 New features to boost your workflow:
|
naglera
force-pushed
the
init-fd
branch
2 times, most recently
from
4570f58 to
07cb2d4
Compare
enjoy-binbin
approved these changes
Jun 9, 2025
madolson
approved these changes
Jun 10, 2025
zuiderkwast
approved these changes
Jun 10, 2025
xbasel
approved these changes
Jun 10, 2025
Member
|
@naglera please merge from unstable and resolve conflicts. |
When sending current offset to replica, use the last selected db sent to the replicas instead of always using `server.db[0]->id`. This fixes a potential issue where the dual channel sync relied on the primary always resending the SELECT command after PSYNC. While the db id argument could be removed from the sync API, it's retained to maintain backward compatibility. Signed-off-by: naglera <[email protected]>
chzhoo
pushed a commit
to chzhoo/valkey
that referenced
this pull request
Jun 12, 2025
…2188) When sending current offset to replica, use the last selected db sent to the replicas instead of always using `server.db[0]->id`. This fixes a potential issue where the dual channel sync relied on the primary always resending the `SELECT` command after PSYNC. While the db id argument could be removed from the sync API, it's retained to maintain backward compatibility. Fixed valkey-io#2194. Signed-off-by: naglera <[email protected]> Signed-off-by: chzhoo <[email protected]>
shanwan1
pushed a commit
to shanwan1/valkey
that referenced
this pull request
Jun 13, 2025
…2188) When sending current offset to replica, use the last selected db sent to the replicas instead of always using `server.db[0]->id`. This fixes a potential issue where the dual channel sync relied on the primary always resending the `SELECT` command after PSYNC. While the db id argument could be removed from the sync API, it's retained to maintain backward compatibility. Fixed valkey-io#2194. Signed-off-by: naglera <[email protected]> Signed-off-by: shanwan1 <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Jun 18, 2025
…2188) When sending current offset to replica, use the last selected db sent to the replicas instead of always using `server.db[0]->id`. This fixes a potential issue where the dual channel sync relied on the primary always resending the `SELECT` command after PSYNC. While the db id argument could be removed from the sync API, it's retained to maintain backward compatibility. Fixed valkey-io#2194. Signed-off-by: naglera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending current offset to replica, use the last selected db sent to the replicas instead of always using
server.db[0]->id. This fixes a potential issue where the dual channel sync relied on the primary always resending theSELECTcommand after PSYNC.While the db id argument could be removed from the sync API, it's retained to maintain backward compatibility.
Fixed #2194.