Converge divergent shard-id persisted in nodes.conf to primary's shard id #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2174 +/- ##
============================================
+ Coverage 71.43% 73.57% +2.13%
============================================
Files 122 122
Lines 66210 73777 +7567
============================================
+ Hits 47300 54281 +6981
- Misses 18910 19496 +586
🚀 New features to boost your workflow:
|
hwware
approved these changes
Jun 5, 2025
PingXie
reviewed
Jun 9, 2025
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
hpatro
force-pushed
the
handle-divergent-shard-id-nodes-conf
branch
from
5c52a9d to
8f658fe
Compare
Collaborator
Author
|
@martinrvisser I tried few scenarios manually, they seem to run fine. Could you try running this patch and see if it helps ? |
Collaborator
Author
|
Test scenarios: All of these load fine. |
@hpatro fine in my tests also, nice work |
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
Member
enjoy-binbin
left a comment
enjoy-binbin
left a comment
There was a problem hiding this comment.
This look correct, please also update the top comment to desc it. So it is somehow like a corrupted (or a outupdated) nodes.conf cause the trouble?
Collaborator
Author
Yes. Updated. |
hpatro
added
the
run-extra-tests
stockholmux
added a commit
to stockholmux/valkey
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Kyle J. Davis <[email protected]>
hpatro
added
the
release-notes
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 21, 2025
…d id (valkey-io#2174) Fixes valkey-io#2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
Merged
zuiderkwast
pushed a commit
that referenced
this pull request
Aug 22, 2025
…d id (#2174) Fixes #2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Sep 16, 2025
…d id (valkey-io#2174) Fixes valkey-io#2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Sep 30, 2025
…d id (valkey-io#2174) Fixes valkey-io#2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Sep 30, 2025
…d id (valkey-io#2174) Fixes valkey-io#2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Sep 30, 2025
…d id (valkey-io#2174) Fixes valkey-io#2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]>
Contributor
|
I tried backporting this one to 7.2 but I couldn't get the test case to pass, so I'm skipping it for now. If anyone wants to help backporting it, feel free to open a PR targeting the 7.2 branch. Some difficulties to note:
|
zuiderkwast
pushed a commit
that referenced
this pull request
Oct 1, 2025
…d id (#2174) Fixes #2171 Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id. --------- Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2171
Handle divergent shard-id across primary and replica from nodes.conf and reconcile all the nodes in the shard to the primary node's shard-id.