Introduce MPTCP for replica #1961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1961 +/- ##
============================================
+ Coverage 70.99% 71.05% +0.06%
============================================
Files 123 123
Lines 65918 66040 +122
============================================
+ Hits 46798 46925 +127
+ Misses 19120 19115 -5
🚀 New features to boost your workflow:
|
xbasel
reviewed
Apr 17, 2025
Contributor
Author
|
@zuiderkwast @xbasel What do you think about the latest version? |
Contributor
|
I haven't looked yet. We are working on patch releases now. I will take a look in a few days. |
zuiderkwast
reviewed
Apr 22, 2025
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
I think this is mostly fine. I have only some minor comments.
Since commit 4a92db9("Introduce MPTCP (valkey-io#1811)"), valkey server starts to support MPTCP. Support MPTCP for replica as client side. Signed-off-by: zhenwei pi <[email protected]>
Signed-off-by: zhenwei pi <[email protected]>
Signed-off-by: zhenwei pi <[email protected]>
Signed-off-by: zhenwei pi <[email protected]>
Contributor
Author
|
Apply @zuiderkwast 's suggestions, force push a commit over 3 commits to fix DCO error. |
zuiderkwast
approved these changes
Apr 23, 2025
zuiderkwast
added
the
release-notes
Contributor
|
@valkey-io/core-team This is the follow-up of MTPCP to allow replication to use MPTCP. I think we already decided about this when we discussed and decided about MPTCP in the meeting some weeks ago. Please comment if you disagree. |
zuiderkwast
added
the
major-decision-approved
xbasel
reviewed
Apr 23, 2025
Signed-off-by: zhenwei pi <[email protected]>
xbasel
reviewed
Apr 23, 2025
Signed-off-by: zhenwei pi <[email protected]>
xbasel
approved these changes
Apr 23, 2025
|
MPTCP is really good! |
rainsupreme
pushed a commit
to rainsupreme/valkey
that referenced
this pull request
May 14, 2025
Allow replicas to use MPTCP in the outgoing replication connection. A new yes/no config is introduced `repl-mptcp`, default `no`. For MPTCP to be used in replication, the primary needs to be configured with `mptcp yes` and the replica with `repl-mptcp yes`. Otherwise, the connection falls back to regular TCP. Follow-up of valkey-io#1811. --------- Signed-off-by: zhenwei pi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow replicas to use MPTCP in the outgoing replication connection.
A new yes/no config is introduced
repl-mptcp, defaultno.For MPTCP to be used in replication, the primary needs to be configured with
mptcp yesand the replica withrepl-mptcp yes. Otherwise, the connection falls back to regular TCP.Follow-up of #1811.
Cc Linux kernel MPTCP maintainer @matttbe @geliangtang @Dwyane-Yan
Cc @xbasel