-
Notifications
You must be signed in to change notification settings - Fork 980
Disable mem usage test case for non-jemalloc allocators #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zuiderkwast
merged 2 commits into
valkey-io:unstable
from
zuiderkwast:disable-memusage-test-non-jemalloc
Feb 8, 2025
Merged
Disable mem usage test case for non-jemalloc allocators #1685
zuiderkwast
merged 2 commits into
valkey-io:unstable
from
zuiderkwast:disable-memusage-test-non-jemalloc
Feb 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Söderqvist <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1685 +/- ##
=========================================
Coverage 71.02% 71.02%
=========================================
Files 121 121
Lines 65254 65255 +1
=========================================
+ Hits 46344 46347 +3
+ Misses 18910 18908 -2
|
Signed-off-by: Viktor Söderqvist <[email protected]>
enjoy-binbin
approved these changes
Feb 8, 2025
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
Attempt to fix non-jemalloc builds by disabling this test case on
non-jemalloc builds:
```
*** [err]: Memory usage of embedded string value in tests/unit/type/string.tcl
Expected '40' to be less than or equal to '32' (context: type eval line 5 cmd {assert_lessthan_equal [r memory usage quux] 32} proc ::test)
```
We can't assume anything about allocation size classes for arbitrary
allocators.
Glibc malloc seems to give usable sizes of 24, 40, 56, 72, 88, 104, ...,
not similar to jemalloc size classes.
Additional change: encode unused robj allocation space in the EMBSTR sds
header. This makes the test case able to correctly calculate the memory
overhead of the different structures in 32-bit builds, where there is
some unused space in the allocation (because the `robj` header is
smaller).
---------
Signed-off-by: Viktor Söderqvist <[email protected]>
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
Attempt to fix non-jemalloc builds by disabling this test case on
non-jemalloc builds:
```
*** [err]: Memory usage of embedded string value in tests/unit/type/string.tcl
Expected '40' to be less than or equal to '32' (context: type eval line 5 cmd {assert_lessthan_equal [r memory usage quux] 32} proc ::test)
```
We can't assume anything about allocation size classes for arbitrary
allocators.
Glibc malloc seems to give usable sizes of 24, 40, 56, 72, 88, 104, ...,
not similar to jemalloc size classes.
Additional change: encode unused robj allocation space in the EMBSTR sds
header. This makes the test case able to correctly calculate the memory
overhead of the different structures in 32-bit builds, where there is
some unused space in the allocation (because the `robj` header is
smaller).
---------
Signed-off-by: Viktor Söderqvist <[email protected]>
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
Attempt to fix non-jemalloc builds by disabling this test case on
non-jemalloc builds:
```
*** [err]: Memory usage of embedded string value in tests/unit/type/string.tcl
Expected '40' to be less than or equal to '32' (context: type eval line 5 cmd {assert_lessthan_equal [r memory usage quux] 32} proc ::test)
```
We can't assume anything about allocation size classes for arbitrary
allocators.
Glibc malloc seems to give usable sizes of 24, 40, 56, 72, 88, 104, ...,
not similar to jemalloc size classes.
Additional change: encode unused robj allocation space in the EMBSTR sds
header. This makes the test case able to correctly calculate the memory
overhead of the different structures in 32-bit builds, where there is
some unused space in the allocation (because the `robj` header is
smaller).
---------
Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-extra-tests
Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)
test-failure
An issue indicating a test failure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix non-jemalloc builds by disabling this test case on non-jemalloc builds:
We can't assume anything about allocation size classes for arbitrary allocators.
Glibc malloc seems to give usable sizes of 24, 40, 56, 72, 88, 104, ..., not similar to jemalloc size classes.
Additional change: encode unused robj allocation space in the EMBSTR sds header. This makes the test case able to correctly calculate the memory overhead of the different structures in 32-bit builds, where there is some unused space in the allocation (because the
robjheader is smaller).