Skip to content

Adding Missing filters to CLIENT LIST and Dedup Parsing #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 15, 2025
Merged

Adding Missing filters to CLIENT LIST and Dedup Parsing #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6bc64ca
adding missing filters to CLIENT LIST and de-dup parsing code
sarthakaggarwal97 Dec 6, 2024
71af240
adding some tests
sarthakaggarwal97 Dec 9, 2024
e479ab8
supporting multiple ids and filters together
sarthakaggarwal97 Dec 11, 2024
f39777e
updating client list json
sarthakaggarwal97 Dec 11, 2024
c6b256b
addressing some comments
sarthakaggarwal97 Dec 11, 2024
6795820
modularizing client command function
sarthakaggarwal97 Dec 16, 2024
6bd6241
addressing comments on modularizing
sarthakaggarwal97 Dec 16, 2024
4c69c3e
amending help command output
sarthakaggarwal97 Dec 20, 2024
b5c78a0
addressing comments
sarthakaggarwal97 Dec 20, 2024
a9f3113
addressing more commments
sarthakaggarwal97 Dec 20, 2024
4dc485e
amending history of client list json
sarthakaggarwal97 Dec 20, 2024
b5c04b3
starting filter client sds as empty
sarthakaggarwal97 Dec 20, 2024
2954154
addressing comments
sarthakaggarwal97 Dec 31, 2024
dcb8afc
addressing comments
sarthakaggarwal97 Jan 2, 2025
8dc8ae0
removing client command function
sarthakaggarwal97 Jan 3, 2025
832dfd2
adding clientCommand as a function for client json
sarthakaggarwal97 Jan 5, 2025
f7b00fb
resolving conflicts and clang formats
sarthakaggarwal97 Jan 10, 2025
110c7d3
refactoring client subcommand function names
sarthakaggarwal97 Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 34 additions & 21 deletions src/commands.def
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/commands/client-caching.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "6.0.0",
"arity": 3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientCachingCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-capa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "8.0.0",
"arity": -3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientCapaCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-getname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "2.6.9",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientGetNameCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-getredir.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "6.0.0",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientGetredirCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-help.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "5.0.0",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientHelpCommand",
"command_flags": [
"LOADING",
"STALE",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "5.0.0",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientIDCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-import-source.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "8.1.0",
"arity": 3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientImportSourceCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "6.2.0",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientInfoCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
7 changes: 6 additions & 1 deletion src/commands/client-kill.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "2.4.0",
"arity": -3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientKillCommand",
"history": [
[
"2.8.12",
Expand Down Expand Up @@ -35,6 +35,10 @@
[
"8.0.0",
"Replaced `master` `TYPE` with `primary`. `master` still supported for backward compatibility."
],
[
"8.1.0",
"`ID` option accepts multiple IDs."
]
],
"command_flags": [
Expand Down Expand Up @@ -68,6 +72,7 @@
"name": "client-id",
"type": "integer",
"optional": true,
"multiple": true,
"since": "2.8.12"
},
{
Expand Down
55 changes: 54 additions & 1 deletion src/commands/client-list.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "2.4.0",
"arity": -2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientListCommand",
"history": [
[
"2.8.12",
Expand Down Expand Up @@ -35,6 +35,10 @@
[
"8.0.0",
"Replaced `master` `TYPE` with `primary`. `master` still supported for backward compatibility."
],
[
"8.1.0",
"Added filters USER, ADDR, LADDR, SKIPME, and MAXAGE"
]
],
"command_flags": [
Expand Down Expand Up @@ -91,6 +95,55 @@
"optional": true,
"multiple": true,
"since": "6.2.0"
},
{
"token": "USER",
"name": "username",
"type": "string",
"optional": true,
"since": "8.1.0"
},
{
"token": "ADDR",
"name": "addr",
"display": "ip:port",
"type": "string",
"optional": true,
"since": "8.1.0"
},
{
"token": "LADDR",
"name": "laddr",
"display": "ip:port",
"type": "string",
"optional": true,
"since": "8.1.0"
},
{
"token": "SKIPME",
"name": "skipme",
"type": "oneof",
"optional": true,
"since": "8.1.0",
"arguments": [
{
"name": "yes",
"type": "pure-token",
"token": "YES"
},
{
"name": "no",
"type": "pure-token",
"token": "NO"
}
]
},
{
"token": "MAXAGE",
"name": "maxage",
"type": "integer",
"optional": true,
"since": "8.1.0"
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-no-evict.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "7.0.0",
"arity": 3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientNoEvictCommand",
"command_flags": [
"ADMIN",
"NOSCRIPT",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-no-touch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "7.2.0",
"arity": 3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientNoTouchCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-pause.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "3.0.0",
"arity": -3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientPauseCommand",
"history": [
[
"6.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-reply.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "3.2.0",
"arity": 3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientReplyCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-setname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "2.6.9",
"arity": 3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientSetNameCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-tracking.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "6.0.0",
"arity": -3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientTrackingCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-trackinginfo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "6.2.0",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientTrackingInfoCommand",
"command_flags": [
"NOSCRIPT",
"LOADING",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-unblock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "5.0.0",
"arity": -3,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientUnblockCommand",
"command_flags": [
"ADMIN",
"NOSCRIPT",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/client-unpause.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"since": "6.2.0",
"arity": 2,
"container": "CLIENT",
"function": "clientCommand",
"function": "clientUnpauseCommand",
"command_flags": [
"ADMIN",
"NOSCRIPT",
Expand Down
1 change: 1 addition & 0 deletions src/commands/client.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"complexity": "Depends on subcommand.",
"group": "connection",
"since": "2.4.0",
"function": "clientCommand",
"arity": -2,
"command_flags": [
"SENTINEL"
Expand Down
Loading
Loading