CMake fixes + README update #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1276 +/- ##
============================================
+ Coverage 70.69% 70.73% +0.04%
============================================
Files 114 115 +1
Lines 63165 63153 -12
============================================
+ Hits 44654 44671 +17
+ Misses 18511 18482 -29
|
Contributor
Author
|
@PingXie the fix you requested (readme updates) is part of this pr |
- Updated README with CMake variable default values - CMake: support for tcmalloc / tcmalloc_minimal is now working - CMake: Lua lib: prefer mkstemp over tmpnam (tmpname is considered insecured) - CMake: use `valkey_pkg_config` to wrap `pkg_check_modules` - Reduced the CMake minimum version to 3.10 (this allows using CMake build on older systems) - CMake: sanitizer flags should be set for valkey-server only (no need for valkey-cli & valkey-benchmark) Signed-off-by: Eran Ifrah <[email protected]>
eifrah-aws
force-pushed
the
cmake-fixes
branch
from
9522380 to
a3a9eea
Compare
ranshid
approved these changes
Nov 14, 2024
|
@PingXie a gentle ping |
PingXie
approved these changes
Nov 22, 2024
Member
PingXie
left a comment
PingXie
left a comment
There was a problem hiding this comment.
LGTM. Great fix to detect the tcmalloc installation path. Thanks @eifrah-aws!
vudiep411
pushed a commit
to vudiep411/valkey
that referenced
this pull request
Nov 26, 2024
Signed-off-by: vudiep411 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READMEwith CMake variable default valuestcmalloc/tcmalloc_minimalis now workingmkstempovertmpnam(tmpnameis considered insecured)valkey_pkg_configto wrappkg_check_modulesto reduce code verbosityvalkey-cli&valkey-benchmark)