Rename output from redis-* to valkey-* for binaries of "--help" "--version"#113
Merged
zuiderkwast merged 2 commits intovalkey-io:unstablefrom Apr 4, 2024
Merged
Conversation
1. valkey-benchmark 2. valkey-cli 3. valkey-server 4. valkey-sentinel 5. valkey-check-rdb 6. valkey-check-aof "--help" "--version" option. Signed-off-by: Lipeng Zhu <[email protected]>
Contributor
|
Hi! Thanks for your help. I think it's safe to merge, but we have #88 doing very similar or overlapping changes. We will try to avoid a lot of merge conflicts so I'll let this one wait for a bit. |
Contributor
|
Hi again. Some of this output has been fixed already in some other PR. Do you want to fix the merge conflicts? I think we can merge it. |
zuiderkwast
approved these changes
Apr 4, 2024
Merged
zuiderkwast
pushed a commit
that referenced
this pull request
Apr 9, 2024
…n" (#113) Rename output from redis-* to valkey-* for binaries: 1. `valkey-benchmark` 2. `valkey-cli` 3. `valkey-server` 4. `valkey-sentinel` 5. `valkey-check-rdb` 6. `valkey-check-aof` "--help" "--version" option. Signed-off-by: Lipeng Zhu <[email protected]>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
…n" (valkey-io#113) Rename output from redis-* to valkey-* for binaries: 1. `valkey-benchmark` 2. `valkey-cli` 3. `valkey-server` 4. `valkey-sentinel` 5. `valkey-check-rdb` 6. `valkey-check-aof` "--help" "--version" option. Signed-off-by: Lipeng Zhu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename output from redis-* to valkey-* for binaries:
valkey-benchmarkvalkey-clivalkey-servervalkey-sentinelvalkey-check-rdbvalkey-check-aof"--help" "--version" option.