Skip to content

Avoid timing issue in diskless-load-swapdb test #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

Avoid timing issue in diskless-load-swapdb test #1077

merged 1 commit into from
Oct 1, 2024

Conversation

@enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Sep 26, 2024

Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

@enjoy-binbin
Avoid timing issue in diskless-load-swapdb test
dcdf581 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin
Copy link
Member Author

enjoy-binbin commented Sep 26, 2024

failed CI:
https://github.com/valkey-io/valkey/actions/runs/10987837289/job/30503299419#step:5:4849

[exception]: Executing test client: CLUSTERDOWN The cluster is down.
CLUSTERDOWN The cluster is down
    while executing
"$replica get $slot0_key"
    ("uplevel" body line 70)
    invoked from within
"uplevel 1 $code"
    (procedure "test" line 58)
    invoked from within
"test "Main db not affected when fail to diskless load" {

@enjoy-binbin enjoy-binbin added the test-failure An issue indicating a test failure label Sep 26, 2024
@codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.62%. Comparing base (bf8183d) to head (dcdf581).
Report is 8 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #1077   +/-   ##
=========================================
  Coverage     70.61%   70.62%           
=========================================
  Files           114      114           
  Lines         61695    61695           
=========================================
+ Hits          43568    43573    +5     
+ Misses        18127    18122    -5

see 11 files with indirect coverage changes

@madolson madolson merged commit 9827eef into valkey-io:unstable Oct 1, 2024
@enjoy-binbin enjoy-binbin deleted the fix_timing_issue branch October 2, 2024 02:30
naglera pushed a commit to naglera/placeholderkv that referenced this pull request Oct 10, 2024
@enjoy-binbin @naglera
Avoid timing issue in diskless-load-swapdb test (valkey-io#1077)
9c5a7d1 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: naglera <[email protected]>
rainsupreme pushed a commit to rainsupreme/valkey that referenced this pull request Oct 11, 2024
@enjoy-binbin @rainsupreme
Avoid timing issue in diskless-load-swapdb test (valkey-io#1077)
d1ba700 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
eifrah-aws pushed a commit to eifrah-aws/valkey that referenced this pull request Oct 20, 2024
@enjoy-binbin @eifrah-aws
Avoid timing issue in diskless-load-swapdb test (valkey-io#1077)
673d4c2 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
@zuiderkwast zuiderkwast moved this to To be backported in Valkey 8.0 Aug 15, 2025
zuiderkwast pushed a commit to vitarb/valkey that referenced this pull request Aug 15, 2025
@enjoy-binbin @zuiderkwast
Avoid timing issue in diskless-load-swapdb test (valkey-io#1077)
6f97863 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
@zuiderkwast zuiderkwast mentioned this pull request Aug 15, 2025
Merged
@zuiderkwast zuiderkwast moved this from To be backported to 8.0.5 in Valkey 8.0 Aug 18, 2025
zuiderkwast pushed a commit to vitarb/valkey that referenced this pull request Aug 21, 2025
@enjoy-binbin @zuiderkwast
Avoid timing issue in diskless-load-swapdb test (valkey-io#1077)
6964827 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast pushed a commit that referenced this pull request Aug 22, 2025
@enjoy-binbin @zuiderkwast
Avoid timing issue in diskless-load-swapdb test (#1077)
c7d08ad 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request Sep 16, 2025
@enjoy-binbin @sarthakaggarwal97
Avoid timing issue in diskless-load-swapdb test (valkey-io#1077)
26d5ad2 
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
@zuiderkwast zuiderkwast removed this from Valkey 7.2 Sep 30, 2025
@zuiderkwast
Copy link
Contributor

zuiderkwast commented Sep 30, 2025

7.2 doesn't have this test suite, so we can skip it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madolson madolson madolson approved these changes

@PingXie PingXie Awaiting requested review from PingXie

Assignees

No one assigned

Labels

test-failure An issue indicating a test failure

Projects

Valkey 8.0
Status: 8.0.5

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enjoy-binbin @zuiderkwast @madolson