-
Notifications
You must be signed in to change notification settings - Fork 72
adds a performance section to the homepage #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stockholmux
wants to merge
4
commits into
valkey-io:main
Choose a base branch
from
stockholmux:performanc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+169
−71
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Example of a homepage performance card. | ||
| # Both `title` and `description` can contain markdown for styles, but not links. | ||
| # [[dashboards]] | ||
| # title = "GETs/SETs on `9.0.0`" | ||
| # description = "Performance dashboard of GETs and SETs on the Valkey 9.0.0 release. Updated on Oct 21, 2025." | ||
| # link = "https://perf-dashboard.valkey.io/public-dashboards/3e45bf8ded3043edaa941331cd1a94e2" | ||
|
|
||
| # Order in this file indicates rendering order. | ||
|
|
||
| [[dashboards]] | ||
| title = "Valkey Performance Dashboards" | ||
| description = "Valkey Performance Dashboards provide a consolidated view of throughput and memory efficiency trends across versions, helping teams validate improvements and identify regressions." | ||
| link = "/performance/" | ||
|
|
||
| # Performance dashboard sections for /performance page | ||
| # Order in this file indicates rendering order. | ||
|
|
||
| [[sections]] | ||
| title = "Throughput Across Versions" | ||
| iframe_url = "https://perf-dashboard.valkey.io/public-dashboards/38ad683dbd06456c829b547d97e2b7da" | ||
| description = "This dashboard visualizes throughput trends across Valkey versions. It helps compare key releases side by side, highlight performance gains from new features. Read more about [Unlocking 1 Million RPS in Valkey](/blog/unlock-one-million-rps/)." | ||
| methodology = "These metrics are generated using the [valkey-perf-benchmark](https://github.com/valkey-io/valkey-perf-benchmark) tool an AWS `c8g.metal.24xl` instance, running a matrix of configurations that vary pipelining (1, 10), I/O threading (1, 9), and with a data size of 512 bytes. To further stabilize results, we apply IRQ tuning by pinning network interrupts away from CPUs dedicated to the server process, and we isolate the server and benchmark client on separate NUMA nodes to remove L3 cache contention." | ||
|
|
||
| [[sections]] | ||
| title = "Memory Overhead Across Versions" | ||
| iframe_url = "https://df0m5orgq2d38.cloudfront.net/public-dashboards/1e3d87a62b794ce9aa81281d8399e4bf" | ||
| description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features. Discover how [our new hash table design](/blog/new-hash-table/) reduces memory overhead." | ||
| methodology = "These benchmarks are generated by starting an empty instance of Valkey for each test, measuring memory usage, then adding 3 million string items of a certain data size, then measuring Valkey memory usage again. We take the increase in memory use, divide by the number of items, and subtract the size of the user data (key and value) to get the extra overhead bytes Valkey uses to track and organize the data. For this graph, we tested every value size from 8B to 128B inclusive, then averaged the numbers for each range in this chart." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: Valkey Performance Dashboards | ||
| template: performance.html | ||
| --- | ||
|
|
||
| Valkey Performance Dashboards provide a consolidated view of throughput and memory efficiency trends across versions, helping teams validate improvements and identify regressions quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {% extends "default.html" %} | ||
|
|
||
| {% block content %} | ||
| <div class="styled-title"> | ||
| <h1>{{ page.title }}</h1> | ||
| </div> | ||
|
|
||
| <div class="width-limiter"> | ||
| <main class="container"> | ||
| {{ page.content | markdown | safe }} | ||
|
|
||
| {% set perf = load_data(path="_data/perf.toml") %} | ||
| {% for section in perf.sections %} | ||
| <section class="performance-section"> | ||
| <h2>{{ section.title }}</h2> | ||
|
|
||
| {% if section.iframe_url %} | ||
| <iframe src="{{ section.iframe_url }}" width="100%" height="600" frameborder="0"></iframe> | ||
| {% endif %} | ||
|
|
||
| {% if section.description %} | ||
| <p>{{ section.description | markdown | safe }}</p> | ||
| {% endif %} | ||
|
|
||
| {% if section.methodology %} | ||
| <h3>Methodology</h3> | ||
| <p>{{ section.methodology | markdown | safe }}</p> | ||
| {% endif %} | ||
| </section> | ||
| {% endfor %} | ||
|
|
||
| <hr> | ||
| <p>For questions about performance or to contribute benchmarking data, visit our <a href="/community/">community | ||
| page</a> or join the discussion on <a href="https://github.com/orgs/valkey-io/discussions">GitHub</a>. | ||
| </p> | ||
| </main> | ||
| </div> | ||
| {% endblock content %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memory overhead is not performance. I'm not sure why we're including this here.