Python: bitpos valkey8

[cyip10]

valkey-io/valkey#118

[Yury-Fridlyand]

Please update docs (lines 40-41)

[Yury-Fridlyand]

It is possible to define end, but skip start. The command won't fail in that case, but will return incorrect data.
Probably we need to create multiple factory methods to protect us from that.

[Yury-Fridlyand]

As another option - we can keep start mandatory. If user wants to omit start - bitpos should be callsed without options

[jamesx-improving]

Agree with the latest comment: keep start mandatory, and when user want to omit both start and end, they can just omit the entire OffsetOptions, as itself is an optoinal parameter to the actual command fucntions, like bitpos(). We probably want to make the same change to Node as well, to keep consistency.

[Yury-Fridlyand]

You need tests for new command signature with version check

[jamesx-improving]

sorry @Yury-Fridlyand what do you mean here? Do you mean the BYTE|BIT option as part of OffsetOptions? If that's the case I think we already have that, please double check. In case if you mean something else please elaborate.

[Yury-Fridlyand]

New combination of parameters is available only on a specific server version, we need to ensure that test won't fail on older servers.

[jamesx-improving]

Mystery solved: it is the BITCOUNT command which also uses OffsetOptions has the valkey 8 change of end become optional. For BITPOS, end is always optional.