Skip to content

Python: Added FUNCTION FLUSH command#1590

Closed
shohamazon wants to merge 2 commits intovalkey-io:mainfrom
shohamazon:python/function-flush
Closed

Python: Added FUNCTION FLUSH command#1590
shohamazon wants to merge 2 commits intovalkey-io:mainfrom
shohamazon:python/function-flush

Conversation

@shohamazon
Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:
This PR is rebased over #1589

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner June 17, 2024 14:33
@shohamazon shohamazon added the python 🐍 Python wrapper label Jun 17, 2024
"""


class FlushMode(Enum):
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to init.py

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have a conflict with #1579 - please double check before merging

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged #1579. Please rebase and update FlushMode(Enum) to serve both commands.

@shohamazon shohamazon force-pushed the python/function-flush branch from cd70b32 to 77b8d00 Compare June 18, 2024 14:16
@shohamazon shohamazon force-pushed the python/function-flush branch from 77b8d00 to 752514c Compare June 18, 2024 14:18

@pytest.mark.parametrize("cluster_mode", [True, False])
@pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3])
async def test_function_load(self, redis_client: RedisClient):
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async def test_function_load(self, redis_client: RedisClient):
async def test_function_load(self, redis_client: TRedisClient):

@acarbonetto
Copy link
Copy Markdown
Contributor

Closing this PR, as the commits have been pulled into #1700.

@shohamazon shohamazon deleted the python/function-flush branch September 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python 🐍 Python wrapper

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants