Skip to content

Conversation

@LinusU
Copy link
Contributor

@LinusU LinusU commented Jun 5, 2025

(note that I did use ChatGPT 4o to help me with parts of this PR, but I've verified the accuracy of everything)

This adds documentation for the DELIFEQ command that I added in valkey-io/valkey#1975

Signed-off-by: Linus Unnebäck <[email protected]>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

Can you also update the page about locking to use DELIFEQ instead of EVAL? https://github.com/valkey-io/valkey-doc/blob/main/topics/distlock.md

We should mention DELIFEQ first, and below we can mention with less focus that before 9.0, you'd have to use the Lua script.

@LinusU
Copy link
Contributor Author

LinusU commented Jun 11, 2025

@zuiderkwast done ✅

Signed-off-by: Linus Unnebäck <[email protected]>
@zuiderkwast
Copy link
Contributor

Thanks Linus! Looks perfect. I was going to merge it, but I just realized the replies are documented in https://github.com/valkey-io/valkey-doc/blob/main/resp2_replies.json and https://github.com/valkey-io/valkey-doc/blob/main/resp3_replies.json and taken from there when the pages are rendered. Can you add the reply info to these too?

(I opened #312 to get rid of this weird setup that we have for unknown historical reasons.)

@LinusU
Copy link
Contributor Author

LinusU commented Jun 13, 2025

@zuiderkwast fixed ✅

@zuiderkwast zuiderkwast merged commit 05e8bb4 into valkey-io:main Jun 13, 2025
1 check passed
@LinusU LinusU deleted the lu-delifeq branch June 13, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants