Conversation
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
| push: | ||
| workflow_dispatch: | ||
| workflow_run: | ||
| workflows: [GitHub CI] |
There was a problem hiding this comment.
This will only run once we push the images to dockerhub
| startswith(env.rcVersion + ".") | ||
| or startswith(env.rcVersion + "-") | ||
| ) and ( | ||
| index("-") |
There was a problem hiding this comment.
This script did not allow -rc versions to get published
hpatro
left a comment
hpatro
left a comment
There was a problem hiding this comment.
For each os type I presume the Dockerfile and docker-entrypoint.sh file is auto generated.
| "alpine": { | ||
| "version": "3.19" | ||
| }, | ||
| "gosu": { |
There was a problem hiding this comment.
Its golang super user https://github.com/tianon/gosu
It is used to step down from root during container startup, specially for entrypoint.
| # Supported tags and respective `Dockerfile` links | ||
| - [`unstable`](https://github.com/valkey-io/valkey-container/blob/master/unstable/debian/Dockerfile) | ||
| - [`unstable-alpine`](https://github.com/valkey-io/valkey-container/blob/master/unstable/alpine/Dockerfile) | ||
| - [`unstable`, `unstable-bookworm`](https://github.com/valkey-io/valkey-container/blob/master/unstable/debian/Dockerfile) |
There was a problem hiding this comment.
Any reason why debian doesn't need to be added as suffix ?
it is done by |
2 participants
Adds 7.2.4-rc1 and updates docker hub descriptions with new tags