Fully abstract valkeyContextFuncs #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizhenwei
changed the title
Contributor
Author
|
Hi @michael-grunder |
- Hide valkeyNetRead & valkeyNetWrite Move valkeyContextDefaultFuncs into net.c, then valkeyNetRead & valkeyNetWrite could be declared as static functions. async.h is no longer needed by valkey.c, that makes valkey.c independent from networking IO specific operations. - Introduce .connect for valkeyContextFuncs Abstract .connect method, then new connection type has a chance to implement its own connect function. Finally, TCP/Unix/Userfd related functions have been removed from valkey.c. - Introduce .set_timeout method, setsockopt is only available for socket family. None-socket transport would fail on this. .set_timeout allows transport specific timeout setting function. Signed-off-by: zhenwei pi <[email protected]>
If necessary private context gets freed first, NULL pointer would be accessed in .close method. The right and safe timing should be .close then .free_privctx. Signed-off-by: zhenwei pi <[email protected]>
Contributor
Author
|
#55 contains this part, so close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valkey.cindependent from networking IO specific operations.valkey.c