feat(isEmail): Disallow emails starting with but not ending with quote #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciffany
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 106 106
Lines 2348 2348
Branches 593 593
=========================================
Hits 2348 2348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sciffany
changed the title
WikiRik
approved these changes
Mar 10, 2023
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
We already have tests in the valid section for this, so looks good to me!
Author
|
Hi, why is merging still blocked after two approving reviews. Thanks! |
Member
You need two approving reviews of people with merge rights, which does not include us |
|
any news? |
Member
|
This has been resolved in #2437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have invalidated all emails where the user part begins with a quotation but does not end with a quotation. Solves #2184
For example, these are invalid emails:
"[email protected]"<[email protected]" [email protected]Reference:
"spaces, quotes, and backslashes may only exist when within quoted strings and preceded by a backslash" ~https://en.wikipedia.org/wiki/Email_address#Examples
Checklist