-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
added Philippines passport number validation #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hey there, |
|
@digambar-t7 since you added both Pakistan and Philippines in #2073 can we close this PR? |
|
Ok @tux-tn, that will be fine 👍 |
|
Thank you, your other PR should be merged soon since everything is good (Sorry, we don't have exact ETA on when PRs get merged) |
Fixes #2066
Hey there,
I just added Philippines regex code in the isPassportNumber file.Actually I'm confused about the other related stuff need to be done related to every change made.Please guide me for other related changes need to be done.
Thank You!