Skip to content

Conversation

@digambar-t7
Copy link
Contributor

@digambar-t7 digambar-t7 commented Oct 12, 2022

Fixes #2066

Hey there,
I just added Philippines regex code in the isPassportNumber file.Actually I'm confused about the other related stuff need to be done related to every change made.Please guide me for other related changes need to be done.
Thank You!

@digambar-t7 digambar-t7 changed the title feat(isPassportNumber): added Philippines passport number validation #2066 feat(isPassportNumber): added Philippines passport number validation Oct 12, 2022
@digambar-t7 digambar-t7 changed the title feat(isPassportNumber): added Philippines passport number validation fixes #2066 feat(isPassportNumber): added Philippines passport number validation Oct 12, 2022
@digambar-t7 digambar-t7 changed the title fixes #2066 feat(isPassportNumber): added Philippines passport number validation feat(isPassportNumber): added Philippines passport number validation Oct 12, 2022
@digambar-t7 digambar-t7 changed the title feat(isPassportNumber): added Philippines passport number validation fixes #2066 : added Philippines passport number validation Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5f3ef07) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2067   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@digambar-t7 digambar-t7 changed the title fixes #2066 : added Philippines passport number validation added Philippines passport number validation Oct 13, 2022
@digambar-t7
Copy link
Contributor Author

Hey there,
Can anyone review this PR?

@tux-tn
Copy link
Member

tux-tn commented Oct 18, 2022

@digambar-t7 since you added both Pakistan and Philippines in #2073 can we close this PR?

@digambar-t7
Copy link
Contributor Author

digambar-t7 commented Oct 18, 2022

Ok @tux-tn, that will be fine 👍
Btw just based out of curiosity, by when would these changes be reflected in the main source code.

@tux-tn
Copy link
Member

tux-tn commented Oct 18, 2022

Thank you, your other PR should be merged soon since everything is good (Sorry, we don't have exact ETA on when PRs get merged)

@tux-tn tux-tn closed this Oct 18, 2022
@tux-tn tux-tn added the duplicate Duplicate issue label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Duplicate issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passport Validations

2 participants