-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(isPostalCode): Add PK (Pakistan) locale #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isPostalCode): Add PK (Pakistan) locale #2052
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2052 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2203 2203
Branches 477 477
=========================================
Hits 2203 2203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thank you for this addition. generally speaking: thank you for providing some official reference for the numbers, and I agree that there should be some place, where all of that information is stored/made available, but I'm not sure if isPostalCode.js would be the best place for that - it would get really messy in that file, otherwise, if every language had 1 or maybe even 2 references in there. |
|
Please fix the merge conflicts |
a56b4d5 to
6fce544
Compare
done |
Added validation and tests for postal code locale
PKReference for valid list of postal codes: https://www.pakpost.gov.pk/postcodes.php
Checklist