Skip to content

Conversation

@mateeni-dev
Copy link
Contributor

Added validation and tests for postal code locale PK

Reference for valid list of postal codes: https://www.pakpost.gov.pk/postcodes.php

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (86a07ba) to head (a56b4d5).
Report is 155 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2052   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pano9000
Copy link
Contributor

thank you for this addition.
it looks good to me, only thing I personally don't like is the link to the URL being inside the isPostalCode.js

generally speaking: thank you for providing some official reference for the numbers, and I agree that there should be some place, where all of that information is stored/made available, but I'm not sure if isPostalCode.js would be the best place for that - it would get really messy in that file, otherwise, if every language had 1 or maybe even 2 references in there.

WikiRik
WikiRik previously approved these changes Mar 28, 2025
@WikiRik WikiRik added the mc-to-land Just merge-conflict standing between the PR and landing. label Mar 28, 2025
@WikiRik
Copy link
Member

WikiRik commented Mar 28, 2025

Please fix the merge conflicts

rubiin
rubiin previously approved these changes Mar 29, 2025
@mateeni-dev mateeni-dev dismissed stale reviews from rubiin and WikiRik via 6fce544 March 29, 2025 20:58
@mateeni-dev mateeni-dev force-pushed the feature/postal-code-pk branch from a56b4d5 to 6fce544 Compare March 29, 2025 20:58
@mateeni-dev
Copy link
Contributor Author

Please fix the merge conflicts

done

@WikiRik WikiRik merged commit b72aabc into validatorjs:master Apr 8, 2025
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants