Skip to content

feat(isMobilePhone): en-GB enhance #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
profnandaa merged 2 commits into from
Jun 1, 2024
+4 −1
Merged

feat(isMobilePhone): en-GB enhance #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6c21b
feat: isMobilePhone en-GB enhance
ihmpavel May 18, 2022
967a039
Merge branch 'master' of https://github.com/validatorjs/validator.js
ihmpavel May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isMobilePhone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const phones = {
'en-AG': /^(?:\+1|1)268(?:464|7(?:1[3-9]|[28]\d|3[0246]|64|7[0-689]))\d{4}$/,
'en-BM': /^(\+?1)?441(((3|7)\d{6}$)|(5[0-3][0-9]\d{4}$)|(59\d{5}$))/,
'en-BS': /^(\+?1[-\s]?|0)?\(?242\)?[-\s]?\d{3}[-\s]?\d{4}$/,
'en-GB': /^(\+?44|0)7\d{9}$/,
'en-GB': /^(\+?44|0)7[1-9]\d{8}$/,
Copy link
Member

@ezkemboi ezkemboi Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tux-tn and @profnandaa, do we need need to allow pagers and personal numbering as part of the phone numbers?
Screenshot 2022-06-03 at 04 57 32

Copy link
Member

@profnandaa profnandaa Jul 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is personal numbering? Are people still using pagers these days?
image

'en-GG': /^(\+?44|0)1481\d{6}$/,
'en-GH': /^(\+233|0)(20|50|24|54|27|57|26|56|23|28|55|59)\d{7}$/,
'en-GY': /^(\+592|0)6\d{6}$/,
Expand Down
3 changes: 3 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8221,6 +8221,9 @@ describe('Validators', () => {
'+443003434751',
'05073456754',
'08001123123',
'07043425232',
'01273884231',
'03332654034',
],
},
{
Expand Down