Skip to content

Conversation

@zlayabekrija
Copy link
Contributor

Adding Bosnian (BA) zip/postal code validator.

  • Updated isPostalCode method with 'BA' key and appropriate regex validator
  • Updated tests to verify solution
  • Updated ReadMe with given key

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #1956 (bd1f22c) into master (c1b21a9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2085      2085           
  Branches       472       472           
=========================================
  Hits          2085      2085           
Impacted Files Coverage Δ
src/lib/isPostalCode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b21a9...bd1f22c. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @zlayabekrija !
LGTM 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Apr 24, 2022
@zlayabekrija
Copy link
Contributor Author

Thanks a lot <3

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contrib! 🎉

@profnandaa profnandaa changed the title update_with_bosnian_postal_code fix: update bosnian, BA postal code Jun 30, 2022
@profnandaa profnandaa merged commit 97d992c into validatorjs:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants