Skip to content

Conversation

@rootkit7628
Copy link

  • Add regex for validate Madagascar phone number

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #1774 (a2860d5) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1774   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...a2860d5. Read the comment docs.

Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex works good @rootkit7628.
Thanks for the PR.
Please make changes on README and add tests.
Please check the work on #1772 to get grasp of what I mean when mention on adding tests and updating readme.

@rootkit7628
Copy link
Author

The regex works good @rootkit7628.
Thanks for the PR.
Please make changes on README and add tests.
Please check the work on #1772 to get grasp of what I mean when mention on adding tests and updating readme.

Ok ! Thanks ✌️

ezkemboi
ezkemboi previously approved these changes Oct 12, 2021
Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need to allow spacing, but @profnandaa and @tux-tn can advise further

@tux-tn
Copy link
Member

tux-tn commented Oct 13, 2021

I am not sure if we need to allow spacing, but @profnandaa and @tux-tn can advise further

Not sure about the spacing too 😅 I can't find an official document from ITU or OMERT concerning mobile phones in madagascar. @rootkit7628 Do you have an official source/reference ?

@rootkit7628
Copy link
Author

I am not sure if we need to allow spacing, but @profnandaa and @tux-tn can advise further

Not sure about the spacing too sweat_smile I can't find an official document from ITU or OMERT concerning mobile phones in madagascar. @rootkit7628 Do you have an official source/reference ?

I've used the one from wikipédia https://en.wikipedia.org/wiki/Telephone_numbers_in_Madagascar and it seems like their source is this document from ITU https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200007F0001PDFE.pdf

@tux-tn
Copy link
Member

tux-tn commented Oct 19, 2021

ITU are always using spaces in their documentation but i think it's more about page layout and easier reading than format. You can't dial a number with spaces anyway

@rootkit7628
Copy link
Author

Ok ! I'll remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants