-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add madagascar mobile phone validation #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rootkit7628
commented
Oct 11, 2021
- Add regex for validate Madagascar phone number
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
ezkemboi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex works good @rootkit7628.
Thanks for the PR.
Please make changes on README and add tests.
Please check the work on #1772 to get grasp of what I mean when mention on adding tests and updating readme.
Ok ! Thanks ✌️ |
Improve Madagascar validation regex to accept whitespace between number Exemple : 034 91 449 33
ezkemboi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we need to allow spacing, but @profnandaa and @tux-tn can advise further
Not sure about the spacing too 😅 I can't find an official document from ITU or OMERT concerning mobile phones in madagascar. @rootkit7628 Do you have an official source/reference ? |
I've used the one from wikipédia https://en.wikipedia.org/wiki/Telephone_numbers_in_Madagascar and it seems like their source is this document from ITU https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200007F0001PDFE.pdf |
|
ITU are always using spaces in their documentation but i think it's more about page layout and easier reading than format. You can't dial a number with spaces anyway |
|
Ok ! I'll remove it |