Skip to content

Conversation

@cowboy-bebug
Copy link
Contributor

Hi there 👋

Contributing a couple of options for isURL to make it more flexible:

  • allow_fragments
    • true by default
    • if set to false, isURL returns false if # is present in url
  • allow_query_components
    • true by default
    • if set to false, isURL returns false if ? or & is present in url

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1721 (29ac979) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1721   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         2005      2009    +4     
  Branches       452       454    +2     
=========================================
+ Hits          2005      2009    +4     
Impacted Files Coverage Δ
src/lib/isURL.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...29ac979. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cowboy-bebug and congrats for your first contribution here 👏 !
LGTM 🎉

@tux-tn tux-tn added 🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed enhancement labels Sep 6, 2021
@cowboy-bebug
Copy link
Contributor Author

Thanks @tux-tn!
When could I expect this to be published? I'd like to consume it as soon as we can 😄

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants