Skip to content

Conversation

@fedeci
Copy link
Contributor

@fedeci fedeci commented Apr 10, 2021

- recieves a string
+ receives a string

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #1640 (a2ad698) into master (63b6162) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1843      1843           
=========================================
  Hits          1843      1843           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...a2ad698. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @fedeci ! Thank you

@tux-tn tux-tn added the ready-to-land For PRs that are reviewed and ready to be landed label Apr 16, 2021
@profnandaa profnandaa merged commit b82f4f2 into validatorjs:master Apr 17, 2021
@fedeci fedeci deleted the patch-1 branch April 17, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants