feat(isMobilePhone) new regex for Latvia lv-LV #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1843 1843
=========================================
Hits 1843 1843
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Apr 16, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM 🎉 !
Thank you for your contribution and welcome !
tux-tn
added
🎉 first-pr
ready-to-land
ezkemboi
approved these changes
Apr 17, 2021
Member
ezkemboi
left a comment
ezkemboi
left a comment
There was a problem hiding this comment.
Looks good, but I was asking myself,
Is there any need for adding exit code to mobile numbers really? e.g 011 from The US and 00 for most countries.
Ccc. @profnandaa and @tux-tn
profnandaa
approved these changes
Apr 17, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contrib, and welcome to the project 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new regex for Latvia (lv-LV) mobile phone numbers in isMobilePhone
Checklist