Skip to content

Do not validate the length of email parts if ignore_max_length is true #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
profnandaa merged 2 commits into from
Sep 18, 2020
Merged

Do not validate the length of email parts if ignore_max_length is true #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9592b43
Do not validate the length of email parts if ignore_max_length is true
evantahler Sep 13, 2020
1f97a1f
fix missing comma
evantahler Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/lib/isEmail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const default_email_options = {
require_display_name: false,
allow_utf8_local_part: true,
require_tld: true,
ignore_max_length: false,
};

/* eslint-disable max-len */
Expand Down Expand Up @@ -118,8 +119,10 @@ export default function isEmail(str, options) {
}
}

if (!isByteLength(user, { max: 64 }) ||
!isByteLength(domain, { max: 254 })) {
if (options.ignore_max_length === false && (
!isByteLength(user, { max: 64 }) ||
!isByteLength(domain, { max: 254 }))
) {
return false;
}

Expand Down
20 changes: 20 additions & 0 deletions test/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,26 @@ describe('Validators', () => {
});
});

it('should validate really long emails if ignore_max_length is set', () => {
test({
validator: 'isEmail',
args: [{ ignore_max_length: false }],
valid: [],
invalid: [
'Deleted-user-id-19430-Team-5051deleted-user-id-19430-team-5051XXXXXX@example.com',
],
});

test({
validator: 'isEmail',
args: [{ ignore_max_length: true }],
valid: [
'Deleted-user-id-19430-Team-5051deleted-user-id-19430-team-5051XXXXXX@example.com',
],
invalid: [],
});
});

it('should validate URLs', () => {
test({
validator: 'isURL',
Expand Down