-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
isAlpha enhancement #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
profnandaa
merged 11 commits into
validatorjs:master
from
mum-never-proud:isAlpha-refactor
Nov 15, 2020
Merged
isAlpha enhancement #1286
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d5291cf
isAlpha enhancement
mum-never-proud 7b198ca
update
mum-never-proud e9bfc4e
testcase
mum-never-proud 5ff4998
revert change
mum-never-proud 5f385de
add escape regex
mum-never-proud 8d4dff5
Merge branch 'master' into isAlpha-refactor
mum-never-proud d432f49
revert index
mum-never-proud 7629bde
enhancements
mum-never-proud 9cd236a
readme
mum-never-proud a919d99
Merge branch 'master' into isAlpha-refactor
mum-never-proud d313ed6
Merge branch 'master' into isAlpha-refactor
mum-never-proud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am with the opinion that
ignorecharacters should be optional.This actually fails if a user does not pass ignore values (It is not guaranteed that a user needs to have some values ignored).
Also, if I pass options as
args: [{ ignore: /[\s/-]/g }], it will fail or I do pass anargs: ['en-US', { }]it also fails.I am open to discussion on way forward.
Cc. @profnandaa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm technically i don't see a possibility of failing for any of the above args, may be i can add those
validator.js/src/lib/isAlpha.js
Lines 8 to 10 in a919d99
the above line says that ignore is optional which means,
args: ['en-US', { }]should passas far as about this
[{ ignore: /[\s/-]/g }]we are already asserting first argument to be stringlet me know if it makes sense @profnandaa @ezkemboi