Skip to content

Conversation

@ahmad-ibra
Copy link
Member

This PR fixes signature verification for private registries

@ahmad-ibra ahmad-ibra requested a review from a team May 14, 2024 20:56
@ahmad-ibra ahmad-ibra marked this pull request as draft May 14, 2024 20:58
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   70.98%   70.99%           
=======================================
  Files           3        3           
  Lines         355      362    +7     
=======================================
+ Hits          252      257    +5     
- Misses         77       78    +1     
- Partials       26       27    +1     
Files Coverage Δ
internal/validators/oci_validator.go 67.26% <100.00%> (ø)
internal/verifier/verifier.go 71.05% <71.42%> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58806a5...4276de3. Read the comment docs.

@ahmad-ibra ahmad-ibra force-pushed the fix/private-registry-signature-verification branch 3 times, most recently from 4131116 to 6011e54 Compare May 14, 2024 21:42
@ahmad-ibra ahmad-ibra force-pushed the fix/private-registry-signature-verification branch from 93312f0 to 08864b3 Compare May 14, 2024 22:09
@ahmad-ibra ahmad-ibra marked this pull request as ready for review May 14, 2024 22:27
TylerGillson
TylerGillson previously approved these changes May 14, 2024
TylerGillson
TylerGillson previously approved these changes May 14, 2024
@ahmad-ibra ahmad-ibra force-pushed the fix/private-registry-signature-verification branch from 549f00c to 2dcf037 Compare May 14, 2024 23:04
@ahmad-ibra ahmad-ibra requested a review from TylerGillson May 14, 2024 23:08
@ahmad-ibra ahmad-ibra merged commit 26d4671 into main May 15, 2024
@ahmad-ibra ahmad-ibra deleted the fix/private-registry-signature-verification branch May 15, 2024 00:00
@ahmad-ibra ahmad-ibra changed the title PLT-1183: fix: Ensure auth options are passed into the Cosign Verifier fix: PLT-1183: Ensure auth options are passed into the Cosign Verifier May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants