onSelectionFinish keeps firing on when unmounted

[Studio384]

Since version 3, when the component that has the SelectableGroup in it unmounts, the onSelectionFinish-event keeps firing (sometimes up to 600+ times).

[snsheth55]

Hey did you figure out a solution to this issue, I am getting a similar error when the component unmounts:

Uncaught TypeError: Cannot read property 'handleSelectionFinish' of null
at App123.handleSelectionFinish (TestArea5.js:51)
at Object.SelectableGroup._this.unregisterSelectable [as unregister] (SelectableGroup.js:187)
at SelectableItem.componentWillUnmount (CreateSelectable.js:101)

[Studio384]

https://github.com/valerybugakov/react-selectable-fast/blob/master/src/SelectableGroup.tsx#L204

This seems to be the offending line. I'm not sure why this behavior would ever be required. Regardless, this illustrates the need for a proper changelog, it wasn't there in 2.3.1.

[valerybugakov]

@snsheth55 handleSelectionFinish sounds like another issue, could you create example with the issue on codesandbox?

[valerybugakov]

@Studio384 the idea of an additional onSelectionFinish call is to notify user that some selected component did unmount and probably should be deleted from the list of the selectedItems. It's a good idea not to call this method if unmounted item is not selected yet to avoid redundant onSelectionFinish calls.

Does it sound reasonable?

[seeden]

I have same issue. I am showing loading after onSelectionFinish and unmount whole component. It will call onSelectionFinish multiple times with bad values.

[romecode]

Seeing the same issue. I have the selection mounted in a tab kind of behavior and when switching tabs onSelectionFinish fn fires.

The firing behavior is such: if I have 6 items selected then it fires 7 times decrementing the passed array until the array.length is 0 i.e.
[6]
[5]
.
.
[0]