Temporarily force v2.8.1 (and some unrelated cleanup)#1
Closed
PaulSD wants to merge 2 commits intovajonam:mainfrom
Closed
Temporarily force v2.8.1 (and some unrelated cleanup)#1PaulSD wants to merge 2 commits intovajonam:mainfrom
PaulSD wants to merge 2 commits intovajonam:mainfrom
Conversation
Author
|
Moved to helfrichmichael#21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrusaSlicer 2.9.0 dropped support for AppImage, and the "replacement" Flatpak builds are not compatible with Docker (and probably wouldn't support VirtualGL without lots of hacking even if you got past the Docker issues). I suspect the best way forward would be to convert this to a two-stage docker build, where the first stage compiles the latest PrusaSlicer from source (in an Ubuntu container), then the second stage builds the runtime image with the compiled copy of PrusaSlicer. However, that isn't a trivial project.
For now, I simply hard-coded v2.8.1, so that the AppImage-based container can continue to be built for v2.8.1
I also cleaned up a few commands to eliminate some warnings when building.