Skip to content

chore(nimble): remove workaround in runTest #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladopajic merged 1 commit into from
Oct 30, 2025
+3 −10
Merged

chore(nimble): remove workaround in runTest #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions libp2p.nimble
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,7 @@ let cfg =

import hashes, strutils

proc runTest(
filename: string, moreoptions: string = "", verboseTestOutput: bool = true
) =
# note: verboseTestOutput was added because `testmultiformatexts` task fails
# when `--output-level` argument is used. we should seek to avoid having this
# argument as all tests should run with verbose output.

proc runTest(filename: string, moreoptions: string = "") =
var compileCmd = nimc & " " & lang & " -d:debug " & cfg & " " & flags
if getEnv("CICOV").len > 0:
compileCmd &= " --nimcache:nimcache/" & filename & "-" & $compileCmd.hash
Expand All @@ -43,8 +37,7 @@ proc runTest(
# step 1: compile test binary
exec compileCmd & " tests/" & filename
# step 2: run binary
exec "./tests/" & filename.toExe &
(if verboseTestOutput: " --output-level=VERBOSE" else: "")
exec "./tests/" & filename.toExe & " --output-level=VERBOSE"
# step 3: remove binary
rmFile "tests/" & filename.toExe

Expand All @@ -68,7 +61,7 @@ task testmultiformatexts, "Run multiformat extensions tests":
"-d:libp2p_multihash_exts=../tests/multiformat_exts/multihash_exts.nim " &
"-d:libp2p_multibase_exts=../tests/multiformat_exts/multibase_exts.nim " &
"-d:libp2p_contentids_exts=../tests/multiformat_exts/contentids_exts.nim "
runTest("multiformat_exts/testmultiformat_exts", opts, false)
runTest("multiformat_exts/testmultiformat_exts", opts)

task testnative, "Runs libp2p native tests":
runTest("testnative")
Expand Down
Loading