Skip to content

Conversation

@emizzle
Copy link
Contributor

@emizzle emizzle commented Oct 14, 2025

Allows Cid codecs to be added as extensions at compile time, such that Cids can be hashed with extended codecs (defined as codec extensions, see #1734).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

🏁 Performance Summary

Commit: ce3c16786db5d354ddae40f5d76be6821e650896

Scenario Nodes Total messages sent Total messages received Latency min (ms) Latency max (ms) Latency avg (ms)
✅ Base Test (QUIC) 10 100 900 0.322 2.256 1.008
✅ Base Test (TCP) 10 100 900 0.447 2.542 1.187

📊 View Container Resources in the Workflow Summary

Latency History

🔵 Min • 🟢 Avg • 🔴 Max

%%{init: {"xyChart": {"width": 500, "height": 200}}}%%
xychart-beta
    title "TCP"
    x-axis "PR Number" 1599 --> 1769
    y-axis "Latency (ms)"
    line "Min" [0.315, 0.429, 0.308, 0.349, 0.397, 0.259, 0.317, 0.333, 0.266, 0.278, 0.322, 0.300, 0.301, 0.302, 0.263, 0.338, 0.288, 0.308, 0.318, 0.313, 0.358, 0.317, 0.274, 0.293, 0.278, 0.312, 0.308, 0.280, 0.296, 0.292, 0.296, 0.296, 0.437, 0.265, 0.444, 0.396, 0.323, 0.305, 0.305, 0.293, 0.333, 0.322, 0.370, 0.273, 0.338, 0.275, 0.318, 0.322, 0.284, 0.278, 0.325, 0.297, 0.275, 0.297, 0.280, 0.277, 0.407, 0.304, 0.329, 0.319, 0.372, 0.289, 0.317, 0.262, 0.298, 0.376, 0.331, 0.257, 0.286, 0.299, 0.267, 0.312, 0.277, 0.240, 0.266, 0.424, 0.235, 0.261, 0.364, 0.422, 0.274, 0.297, 0.313, 0.291, 0.317, 0.356, 0.274, 0.222, 0.290, 0.253, 0.319, 0.268, 0.303, 0.246, 0.304, 0.316, 0.217, 0.252, 0.431, 0.247, 0.291, 0.267, 0.424, 0.392, 0.247, 0.335, 0.447, 0.289, 0.251, 0.361, 0.400, 0.242, 0.323, 0.398]
    line "Avg" [1.042, 1.134, 1.015, 1.035, 1.177, 0.899, 1.040, 1.085, 0.860, 1.015, 1.020, 0.945, 0.986, 1.074, 0.899, 0.975, 0.958, 1.027, 0.959, 1.047, 1.103, 1.046, 0.908, 0.882, 0.896, 1.064, 1.011, 0.957, 0.991, 0.923, 0.867, 0.959, 1.126, 0.910, 1.125, 1.085, 0.983, 1.049, 1.053, 1.056, 1.080, 0.989, 1.137, 1.007, 1.062, 0.874, 1.065, 1.137, 0.974, 0.852, 1.080, 0.991, 1.003, 1.017, 0.971, 1.068, 1.026, 1.054, 1.100, 1.054, 1.087, 0.961, 0.886, 0.878, 1.028, 1.247, 1.023, 0.887, 1.015, 0.952, 0.875, 0.985, 1.003, 0.997, 0.982, 1.178, 0.804, 0.839, 1.092, 1.110, 0.850, 1.026, 0.996, 0.959, 1.046, 1.083, 0.907, 0.852, 0.933, 0.953, 1.103, 0.932, 1.033, 0.974, 0.901, 1.042, 0.807, 0.838, 1.146, 1.110, 0.967, 0.981, 1.092, 1.065, 0.905, 1.053, 1.187, 0.955, 0.857, 1.106, 1.137, 0.845, 1.215, 1.115]
    line "Max" [2.298, 2.513, 2.647, 2.370, 2.486, 2.258, 2.316, 2.407, 2.065, 3.120, 2.328, 2.193, 2.359, 2.398, 2.082, 2.241, 2.339, 2.187, 2.267, 2.268, 2.480, 2.591, 2.231, 1.950, 2.493, 2.596, 2.270, 2.198, 2.587, 2.539, 1.811, 2.355, 2.373, 2.516, 2.368, 2.412, 2.166, 2.482, 2.401, 2.505, 2.396, 2.211, 2.686, 2.876, 2.527, 2.543, 2.441, 2.495, 2.270, 2.073, 2.354, 2.257, 2.217, 2.562, 2.383, 3.300, 2.337, 2.394, 2.521, 2.316, 2.490, 2.352, 2.218, 2.233, 2.267, 2.836, 2.352, 2.316, 2.371, 2.306, 1.972, 2.273, 2.457, 2.517, 2.295, 2.685, 1.995, 1.988, 2.495, 2.309, 2.154, 2.482, 2.433, 2.387, 2.387, 2.335, 2.411, 2.018, 2.145, 2.515, 2.441, 2.129, 2.243, 2.354, 2.225, 2.359, 2.232, 2.120, 3.212, 3.323, 2.256, 2.348, 2.423, 2.484, 2.275, 2.245, 2.542, 2.492, 2.067, 2.443, 2.400, 1.924, 2.732, 2.455]
Loading
%%{init: {"xyChart": {"width": 500, "height": 200}}}%%
xychart-beta
    title "QUIC"
    x-axis "PR Number" 1685 --> 1769
    y-axis "Latency (ms)"
    line "Min" [0.214, 0.000, 0.325, 0.229, 0.000, 0.000, 0.208, 0.223, 0.000, 0.000, 0.000, 0.000, 0.271, 0.203, 0.186, 0.000, 0.219, 0.254, 0.000, 0.000, 0.338, 0.000, 0.000, 0.207, 0.268, 0.221, 0.229, 0.000, 0.322, 0.000, 0.205, 0.000, 0.368, 0.000, 0.000, 0.324]
    line "Avg" [0.750, 0.259, 1.020, 0.856, 0.725, 0.602, 0.893, 0.875, 0.661, 0.557, 0.731, 0.796, 0.949, 0.726, 0.849, 0.761, 0.718, 0.939, 0.550, 0.561, 0.943, 0.832, 0.807, 0.867, 0.947, 1.098, 0.991, 0.608, 1.008, 0.530, 0.823, 0.822, 1.001, 0.457, 0.789, 1.114]
    line "Max" [1.906, 0.821, 1.944, 1.917, 1.681, 1.573, 1.837, 1.857, 1.782, 1.274, 1.783, 2.676, 2.006, 1.943, 2.179, 1.918, 1.755, 1.959, 1.371, 1.455, 1.958, 2.546, 1.978, 1.997, 2.069, 2.434, 2.289, 1.541, 2.256, 1.587, 1.879, 1.830, 2.144, 1.417, 1.840, 2.972]
Loading

@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Oct 15, 2025
Allows Cid codecs to be added as extensions at compile time, such that Cids can be hashed with extended codecs (defined as codec extensions)
@emizzle emizzle force-pushed the feat/multiformats/add-cid-extensions branch from a93e634 to c34ced6 Compare October 16, 2025 10:51
@emizzle
Copy link
Contributor Author

emizzle commented Oct 16, 2025

Just rebased on top of master, so should be g2g after green lights 👍

@richard-ramos richard-ramos enabled auto-merge (squash) October 16, 2025 13:23
@richard-ramos richard-ramos merged commit 0de4436 into master Oct 16, 2025
17 checks passed
@richard-ramos richard-ramos deleted the feat/multiformats/add-cid-extensions branch October 16, 2025 14:05
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants