-
Notifications
You must be signed in to change notification settings - Fork 66
feat(mix): serialization #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(mix): serialization #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🏁 Performance SummaryCommit:
📊 View Latency History and full Container Resources in the Workflow Summary |
vladopajic
approved these changes
Sep 14, 2025
gmelodie
requested changes
Sep 15, 2025
Comment on lines
67
to
87
| proc init*(T: typedesc[Hop], multiAddress: seq[byte]): T = | ||
| T( | ||
| MultiAddress: | ||
| if multiAddress == newSeq[byte](addrSize): | ||
| @[] | ||
| else: | ||
| multiAddress | ||
| ) | ||
|
|
||
| proc getHop*(hop: Hop): seq[byte] = | ||
| return hop.MultiAddress |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, we won't need this
Suggested change
| proc init*(T: typedesc[Hop], multiAddress: seq[byte]): T = | |
| T( | |
| MultiAddress: | |
| if multiAddress == newSeq[byte](addrSize): | |
| @[] | |
| else: | |
| multiAddress | |
| ) | |
| proc getHop*(hop: Hop): seq[byte] = | |
| return hop.MultiAddress |
eb758f0 to
0cd7c65
Compare
abbacdf to
2866e04
Compare
b219f1c to
76c73cd
Compare
76c73cd to
55f6a78
Compare
gmelodie
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds these files from mix repo and their tests