Skip to content

Conversation

@richard-ramos
Copy link
Member

Adds these files from mix repo and their tests

@richard-ramos richard-ramos requested a review from a team as a code owner September 12, 2025 19:28
@richard-ramos richard-ramos requested review from gmelodie and vladopajic and removed request for a team September 12, 2025 19:28
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

🏁 Performance Summary

Commit: 60997ec4defefdf39b1f0e4c6d6c2cd87cd7b7e0

Scenario Nodes Total messages sent Total messages received Latency min (ms) Latency max (ms) Latency avg (ms)
Base test 10 100 900 0.275 2.217 1.003
Low Bandwidth rate 256kbit burst 8kbit limit 5000 10 100 900 0.212 56.354 8.053
Packet Reorder 15% 40% with 2ms delay 10 100 900 0.236 5.488 2.999
Queue Limit 5 10 100 900 0.252 2.726 0.923
Latency 100ms 20ms 10 100 900 20.281 227.035 119.052
Burst Loss 8% 30% 10 100 900 0.338 2.276 0.983
Duplication 2% 10 100 900 0.257 2.221 0.921
Corruption 0.5% 10 100 900 0.312 2.493 0.926
Packet Loss 5% 10 100 900 0.324 2.401 1.071
Combined Network Conditions 10 100 900 0.206 328.620 130.474

📊 View Latency History and full Container Resources in the Workflow Summary

@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Sep 14, 2025
Comment on lines 67 to 87
proc init*(T: typedesc[Hop], multiAddress: seq[byte]): T =
T(
MultiAddress:
if multiAddress == newSeq[byte](addrSize):
@[]
else:
multiAddress
)

proc getHop*(hop: Hop): seq[byte] =
return hop.MultiAddress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, we won't need this

Suggested change
proc init*(T: typedesc[Hop], multiAddress: seq[byte]): T =
T(
MultiAddress:
if multiAddress == newSeq[byte](addrSize):
@[]
else:
multiAddress
)
proc getHop*(hop: Hop): seq[byte] =
return hop.MultiAddress

Base automatically changed from feat/mix/seqnotag to master September 15, 2025 19:49
@richard-ramos richard-ramos enabled auto-merge (squash) September 15, 2025 20:16
@richard-ramos richard-ramos merged commit 34a9a03 into master Sep 16, 2025
15 of 16 checks passed
@richard-ramos richard-ramos deleted the feat/mix/serialization branch September 16, 2025 14:12
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants