Skip to content

chore(quic): add tests from common interop - #1662

Merged
vladopajic merged 14 commits into
masterfrom
quic-add-common-test
Sep 8, 2025
Merged

chore(quic): add tests from common interop#1662
vladopajic merged 14 commits into
masterfrom
quic-add-common-test

Conversation

@vladopajic

@vladopajic vladopajic commented Sep 4, 2025

Copy link
Copy Markdown
Member
  • quic transport can now dial without starting (to have same behavior as other transports)
  • added tests from common interop

closes: #1652

@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

🏁 Performance Summary

Commit: 4abe77a894b8a87c52e830fdc80a44f7f388ce95

Scenario Nodes Total messages sent Total messages received Latency min (ms) Latency max (ms) Latency avg (ms)
Base test 10 100 900 0.292 2.539 0.923
Low Bandwidth rate 256kbit burst 8kbit limit 5000 10 100 900 0.175 43.641 6.990
Packet Reorder 15% 40% with 2ms delay 10 100 900 0.262 5.447 2.887
Queue Limit 5 10 100 900 0.284 2.330 0.911
Latency 100ms 20ms 10 100 900 20.252 216.956 115.405
Burst Loss 8% 30% 10 100 900 0.307 2.396 0.955
Duplication 2% 10 100 900 0.309 2.368 0.933
Corruption 0.5% 10 100 900 0.271 2.099 0.884
Packet Loss 5% 10 100 900 0.290 2.363 0.925
Combined Network Conditions 10 100 900 0.216 237.753 117.149

📊 View Latency History and full Container Resources in the Workflow Summary

@vladopajic vladopajic changed the title quic: add tests chore(quic): add cancellation tests Sep 4, 2025
@vladopajic vladopajic changed the title chore(quic): add cancellation tests chore(quic): add tests from common interop Sep 4, 2025
@vladopajic
vladopajic marked this pull request as ready for review September 4, 2025 12:24
@vladopajic
vladopajic requested a review from a team as a code owner September 4, 2025 12:24
Comment thread .pinned Outdated
ngtcp2;https://github.com/status-im/nim-ngtcp2@#9456daa178c655bccd4a3c78ad3b8cce1f0add73
nimcrypto;https://github.com/cheatfate/nimcrypto@#19c41d6be4c00b4a2c8000583bd30cf8ceb5f4b1
quic;https://github.com/vacp2p/nim-quic@#cae13c2d22ba2730c979486cf89b88927045c3ae
quic;https://github.com/vacp2p/nim-quic@#1d1f2a8bd046ee44c48e1ac655d77cb9636ddd13

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes fix with QuicClient dial cancellation

@vladopajic
vladopajic enabled auto-merge (squash) September 4, 2025 13:37

@gmelodie gmelodie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the common interop tests anywhere. Am I missing something?

@vladopajic

Copy link
Copy Markdown
Member Author

I can't find the common interop tests anywhere. Am I missing something?

only specific tests from there are ported to quick tests

@github-project-automation github-project-automation Bot moved this from new to In Progress in nim-libp2p Sep 8, 2025
@vladopajic
vladopajic merged commit c3faabf into master Sep 8, 2025
15 of 16 checks passed
@vladopajic
vladopajic deleted the quic-add-common-test branch September 8, 2025 16:06
@github-project-automation github-project-automation Bot moved this from In Progress to done in nim-libp2p Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

quic: testquic.nim does not use commontransport.nim

3 participants