fix(tests): prevent race condition in testgossipsubcontrolmessages #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorganaFuture
force-pushed
the
MorganaFuture/fix/flaky_test_IHAVE_for_message_not_held_by_peer_triggers_IWANT_response_to_sender
branch
from
1281031 to
d86c986
Compare
Contributor
Author
|
@vladopajic could you please rerun? |
Ben-PH
approved these changes
Aug 14, 2025
Contributor
Ben-PH
left a comment
Ben-PH
left a comment
There was a problem hiding this comment.
LGTM. I'll leave it to your judgement about the nature of my review comment.
gmelodie
approved these changes
Aug 14, 2025
Wait for actual message receipt instead of fixed timeout.
MorganaFuture
force-pushed
the
MorganaFuture/fix/flaky_test_IHAVE_for_message_not_held_by_peer_triggers_IWANT_response_to_sender
branch
from
74bf4c0 to
0cea810
Compare
…sage_not_held_by_peer_triggers_IWANT_response_to_sender
…sage_not_held_by_peer_triggers_IWANT_response_to_sender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for actual message receipt instead of fixed timeout.
Links: Issue:1626