Skip to content

Conversation

@Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented Aug 8, 2025

The original intent of this file was to model the required constraints in the type system through patterns such as the typestate pattern, however this does not fit into ergonomic or idiomatic nim cod, and so this idea has been abandoned.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

🏁 Performance Summary

Commit: 975cac759a5737d34aa952249d7bacefdb394874

Scenario Nodes Total messages sent Total messages received Latency min (ms) Latency max (ms) Latency avg (ms)
Base test 10 100 900 0.349 2.370 1.035
Low Bandwidth rate 256kbit burst 8kbit limit 5000 10 100 900 0.318 32.259 4.868
Packet Reorder 15% 40% with 2ms delay 10 100 900 0.283 5.788 2.874
Queue Limit 5 10 100 900 0.278 2.364 1.026
Latency 100ms 20ms 10 100 900 43.373 209.022 114.034
Burst Loss 8% 30% 10 100 900 0.322 2.461 1.048
Duplication 2% 10 100 900 0.325 2.542 1.092
Corruption 0.5% 10 100 900 0.305 2.258 1.034
Packet Loss 5% 10 100 900 0.294 2.460 1.042
Combined Network Conditions 10 100 900 0.277 280.194 124.490

📊 View Latency History and full Container Resources in the Workflow Summary

Base automatically changed from kad-putval to master August 12, 2025 10:25
@Ben-PH Ben-PH force-pushed the kad-dhtype_refactor branch from 6176d11 to d7cd6d9 Compare August 12, 2025 10:27
@Ben-PH Ben-PH force-pushed the kad-dhtype_refactor branch from d7cd6d9 to 49c8050 Compare August 14, 2025 12:02
@Ben-PH Ben-PH marked this pull request as ready for review August 14, 2025 12:07
@Ben-PH Ben-PH requested a review from a team as a code owner August 14, 2025 12:07
@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Aug 15, 2025
@Ben-PH Ben-PH enabled auto-merge (squash) August 15, 2025 11:21
@Ben-PH Ben-PH merged commit ef20f46 into master Aug 15, 2025
29 of 30 checks passed
@Ben-PH Ben-PH deleted the kad-dhtype_refactor branch August 15, 2025 12:23
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants