-
Notifications
You must be signed in to change notification settings - Fork 66
chore(pubsub): simplify prune backoff test #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| await sleepAsync(pruneBackoff.div(2)) | ||
| check: | ||
| node0.mesh.getOrDefault(topic).len == newDValues.get.dHigh.get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed because there is no need to check that current values (dValues) are not applied.
| # When pruneBackoff period is done | ||
| await sleepAsync(pruneBackoff) | ||
|
|
||
| # Then on the next heartbeat mesh is rebalanced and peers are regrafted to the initial d value | ||
| check: | ||
| checkUntilTimeout: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkUntilTimeout is more robust that await sleepAsync(pruneBackoff)
rlve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough 👍
🏁 Performance SummaryCommit:
|
because it's vary flaky with quic