Skip to content

Conversation

@vladopajic
Copy link
Member

because it's vary flaky with quic

@vladopajic vladopajic changed the title chore(gossipsub): simplify prune backoff test chore(pubsub): simplify prune backoff test Aug 5, 2025
Comment on lines -338 to -340
await sleepAsync(pruneBackoff.div(2))
check:
node0.mesh.getOrDefault(topic).len == newDValues.get.dHigh.get
Copy link
Member Author

@vladopajic vladopajic Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because there is no need to check that current values (dValues) are not applied.

Comment on lines 342 to 339
# When pruneBackoff period is done
await sleepAsync(pruneBackoff)

# Then on the next heartbeat mesh is rebalanced and peers are regrafted to the initial d value
check:
checkUntilTimeout:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkUntilTimeout is more robust that await sleepAsync(pruneBackoff)

@vladopajic vladopajic requested a review from rlve August 5, 2025 13:39
Copy link
Contributor

@rlve rlve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough 👍

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

🏁 Performance Summary

Commit: ad73721b99e800d4b8105a48afff6a3053fa7599

Scenario Nodes Total messages sent Total messages received Latency min (ms) Latency max (ms) Latency avg (ms)
Base test 10 100 900 0.286 2.373 0.948
Low Bandwidth rate 256kbit burst 8kbit limit 5000 10 100 900 0.254 77.980 13.820
Packet Reorder 15% 40% with 2ms delay 10 100 900 0.222 5.692 3.038
Queue Limit 5 10 100 900 0.322 2.511 0.965
Latency 100ms 20ms 10 100 900 41.766 234.944 113.505
Burst Loss 8% 30% 10 100 900 0.331 2.467 1.014
Duplication 2% 10 100 900 0.320 2.299 1.012
Corruption 0.5% 10 100 900 0.325 2.493 0.977
Packet Loss 5% 10 100 900 0.272 2.229 0.978
Combined Network Conditions 10 100 900 0.225 220.382 113.858

@vladopajic vladopajic marked this pull request as ready for review August 5, 2025 13:47
@vladopajic vladopajic requested a review from a team as a code owner August 5, 2025 13:47
@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Aug 6, 2025
@vladopajic vladopajic enabled auto-merge (squash) August 7, 2025 07:10
@vladopajic vladopajic merged commit 5dbf077 into master Aug 9, 2025
37 of 42 checks passed
@vladopajic vladopajic deleted the test-gossipsub-test-impr branch August 9, 2025 17:49
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants