Skip to content

Conversation

@richard-ramos
Copy link
Member

Adds a -d:libp2p_autotls_support flag to enable the usage of AutoTLS
As suggested by @arnetheduck, we're disabling this feature, as any additional dependency is a potential security issue.
cc: @tersec

@richard-ramos richard-ramos requested a review from a team as a code owner July 14, 2025 12:37
@richard-ramos richard-ramos force-pushed the chore/hide-autotls branch 4 times, most recently from e868a35 to dc0b82a Compare July 14, 2025 13:03
@@ -1,509 +1,519 @@
import options, sequtils, strutils, json, uri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if what's the better way to do this.

  • could we leave types and types definitions but just remove withAutotls method in switch - then we technically disabled the feature?
  • adding when defined(libp2p_autotls_support): in front of whole file removes line history (sometimes vary interesting info)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the long-term plan is to integrate -d support with nimble feature flags using some suitable convention that has yet to be set in stone - it might be worth to experiment with newer nimble versions to understand what this could look like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we leave types and types definitions but just remove withAutotls method in switch - then we technically disabled the feature?

I can try this.

it might be worth to experiment with newer nimble versions.

This sounds good, but lets do it on a separate PR whose scope is experimenting with that feature, while getting this PR merged ASAP to fix the error found by @jakubgs

@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Jul 14, 2025
@richard-ramos richard-ramos merged commit eee8341 into master Jul 14, 2025
22 of 23 checks passed
@richard-ramos richard-ramos deleted the chore/hide-autotls branch July 14, 2025 17:52
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants