Skip to content

Conversation

@rlve
Copy link
Contributor

@rlve rlve commented Jun 18, 2025

Changes:

  • organise GossipSub Behavior tests - rename and group by method

@rlve rlve requested a review from a team as a code owner June 18, 2025 14:04
@rlve rlve requested review from gmelodie and richard-ramos and removed request for a team June 18, 2025 14:04
@rlve rlve requested a review from vladopajic June 18, 2025 14:06
Copy link
Contributor

@gmelodie gmelodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should group these using suites suite "handleIHave" instead of naming asyncTest "handleIHave - ..."

@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Jun 20, 2025
@rlve
Copy link
Contributor Author

rlve commented Jun 20, 2025

I wonder if we should group these using suites suite "handleIHave" instead of naming asyncTest "handleIHave - ..."

@gmelodie
I tried to group them by suites, but didn't really like the outcome. This way is not ideal, but I liked it better. The best way would be to have nested suites, but that unfortunately doesn't work.

Base automatically changed from test-gossipsub-scoring-3 to master June 24, 2025 13:43
@rlve rlve force-pushed the test-gossipsub-scoring-4 branch from e65f1af to 3095c36 Compare June 24, 2025 13:49
@rlve rlve enabled auto-merge (squash) June 24, 2025 13:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (848fdde) to head (3095c36).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   84.91%   84.46%   -0.45%     
==========================================
  Files         103      107       +4     
  Lines       18129    18071      -58     
==========================================
- Hits        15394    15264     -130     
- Misses       2735     2807      +72     

see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rlve rlve merged commit d1cfbb3 into master Jun 24, 2025
23 of 24 checks passed
@rlve rlve deleted the test-gossipsub-scoring-4 branch June 24, 2025 14:18
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants