Skip to content

Conversation

@richard-ramos
Copy link
Member

Requires: vacp2p/nim-quic#79

Fixes the error seen here: https://github.com/vacp2p/nim-libp2p/actions/runs/15193656027/job/42732413624?pr=1392 that happens frequently with zig, due to them sending a reset when shutting down a stream

   dialer-1    | Traceback (most recent call last)
  dialer-1    | /app/nim-libp2p/tests/transport-interop/main.nim(110) main
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/chronos-#b55e2816eb45f698ddaca8d8473e401502562db2/chronos/internal/asyncfutures.nim(638) waitFor
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/chronos-#b55e2816eb45f698ddaca8d8473e401502562db2/chronos/internal/asyncfutures.nim(624) pollFor
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/chronos-#b55e2816eb45f698ddaca8d8473e401502562db2/chronos/internal/asyncengine.nim(150) poll
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/chronos-#b55e2816eb45f698ddaca8d8473e401502562db2/chronos/transports/datagram.nim(463) readDatagramLoop
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/chronos-#b55e2816eb45f698ddaca8d8473e401502562db2/chronos/transports/datagram.nim(723) wrap
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/api.nim(112) onReceive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/connection.nim(195) receive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/quicconnection.nim(85) receive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/quicconnection.nim(42) receive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/ngtcp2/connection/openstate.nim(109) receive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/ngtcp2/native/connection.nim(201) receive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/ngtcp2/native/connection.nim(196) receive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/ngtcp2/native/connection.nim(183) tryReceive
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/ngtcp2/native/streams.nim(67) onStreamReset
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/stream.nim(78) onClose
  dialer-1    | /app/nim-libp2p/nimbledeps/pkgs/quic-#892feade77cfd84692026f8123c8825d8f2273c8/quic/transport/stream.nim(36) onClose
  dialer-1    | SIGSEGV: Illegal storage access. (Attempt to read from nil?)

@richard-ramos richard-ramos requested a review from a team as a code owner May 23, 2025 22:23
@richard-ramos richard-ramos force-pushed the fix/interop branch 2 times, most recently from ef17059 to 5946007 Compare May 23, 2025 23:17
@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p May 26, 2025
@richard-ramos richard-ramos enabled auto-merge (squash) May 26, 2025 14:44
@richard-ramos richard-ramos disabled auto-merge May 26, 2025 16:15
@richard-ramos richard-ramos merged commit c3dae6a into master May 26, 2025
23 of 24 checks passed
@richard-ramos richard-ramos deleted the fix/interop branch May 26, 2025 16:16
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p May 26, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (ccb24b5) to head (6bbd6cf).
Report is 26 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage   84.64%   84.62%   -0.03%     
==========================================
  Files          97       97              
  Lines       17522    17460      -62     
==========================================
- Hits        14832    14776      -56     
+ Misses       2690     2684       -6     

see 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants