Bincount #738
Merged
Bincount #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwagyeman
reviewed
Aug 25, 2025
code/numpy/compare.c
Outdated
| #if ULAB_MAX_DIMS > 1 | ||
| // no need to check anything, if the maximum number of dimensions is 1 | ||
| if(input->ndim != 1) { | ||
| mp_raise_ValueError(MP_ERROR_TEXT("object too deep for desired arrayy")); |
Owner
Author
There was a problem hiding this comment.
Indeed, thanks for catching it!
Owner
Author
|
@kwagyeman I think the implementation is complete, however, I haven't checked all cases, when something could go wrong, like what happens, if |
Owner
Author
|
Many thanks, this is a rather detailed test suite. I think the code is complete now. If you agree, I'll write up the documentation, and merge. |
|
LTGM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the feature request in #737.