Lowercase delegate methods so bridged symbols don't conflict in Swift#28
Merged
uzysjung merged 2 commits intouzysjung:masterfrom Jan 26, 2015
Merged
Lowercase delegate methods so bridged symbols don't conflict in Swift#28uzysjung merged 2 commits intouzysjung:masterfrom
uzysjung merged 2 commits intouzysjung:masterfrom
Conversation
Owner
|
thank you. #14 |
uzysjung
added a commit
that referenced
this pull request
Jan 26, 2015
Lowercase delegate methods so bridged symbols don't conflict in Swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use this lib in swift and these methods caused a naming conflict with the class name when imported via a bridged header. Lowercasing the first letter in delegate method names is more conventional and fixes the bug